Merge pull request #3709 from ahg-g/mutable-stable

KEP-2926: Graduate mutable scheduling directives to stable

Author: k8s-ci-robot

keps/prod-readiness/sig-scheduling/2926.yaml

@@ -1,3 +1,5 @@
 kep-number: 2926
 beta:
   approver: "@wojtek-t"
+stable:
+  approver: "@wojtek-t"

keps/sig-scheduling/2926-job-mutable-scheduling-directives/README.md

@@ -162,8 +162,8 @@ specific partition (e.g., preemptibles) or a specific location (e.g., zone x).
 
 This is a proposal to relax update validation on jobs that have never been unsuspended to 
 allow mutating node scheduling directives, namely the pod template's node affinity, 
-node selector, tolerations, annotations and labels of the job's pod template. This enables 
-a higher-level queue controller to inject such directives before un-suspending a job to
+node selector, tolerations, schedulingGates, annotations and labels of the job's pod template. This 
+enables a higher-level queue controller to inject such directives before un-suspending a job to
 influence its placement.
 
 <!--
@@ -534,7 +534,8 @@ kube-apiserver will accept node affinity/tolerations updates of jobs.
 
 ###### Are there any tests for feature enablement/disablement?
 
-No, unit and integration tests will be added prior to Beta graduation.
+Tests are in place. See [Job integrations tests](https://github.com/kubernetes/kubernetes/blob/457341c3d408097025af5a9b6f5917439c0debdd/test/integration/job/job_test.go#L1397).
+The tests do not directly test switching between enable/disable, that was tested manually (see below).
 
 <!--
 The e2e framework does not currently support enabling or disabling feature
@@ -551,7 +552,8 @@ This section must be completed when targeting beta to a release.
 
 ###### How can a rollout or rollback fail? Can it impact already running workloads?
 
-The change is opt-in, it doesn't impact already running workloads.
+The change is opt-in, it doesn't impact already running workloads. But problems with the 
+updated validation logic may cause crashes in the apiserver.
 
 <!--
 Try to be as paranoid as possible - e.g., what if some components will restart
@@ -565,7 +567,7 @@ will rollout across nodes.
 
 ###### What specific metrics should inform a rollback?
 
-N/A
+Crashes in the apiserver because of potential problems with the updated validation logic.
 
 <!--
 What signals should users be paying attention to when the feature is young
@@ -574,7 +576,16 @@ that might indicate a serious problem?
 
 ###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
 
-It will be tested manually prior to beta launch.
+Tested manually. 
+1. Cluster on 1.22 was upgraded to 1.23
+2. Created a suspended job
+3. Mutated scheduling directives and checked that mutation was successful
+4. Started the job, verifying that the mutation took effect in practice as well
+5. Created a suspended job
+6. Downgraded the cluster back to 1.22
+7. Attempt to mutate the scheduling directives was rejected.
+
+Findings: the feature and the cluster are behaving as expected.
 
 <!--
 Describe manual testing that was done and the outcomes.
@@ -820,7 +831,9 @@ N/A.
 ## Implementation History
 
 - 2021-09-01: Proposed KEP starting in beta status.
-- 2021-10-28: Updated the KEP to include annotations and labels of the pod template
+- 2021-10-28: Updated the KEP to include annotations and labels of the pod template.
+- 2023-01-03: Updated the KEP to include schedulingGates of the pod template and graduated the feature to stable.
+
 
 <!--
 Major milestones in the lifecycle of a KEP should be tracked in this section.

keps/sig-scheduling/2926-job-mutable-scheduling-directives/kep.yaml

@@ -18,17 +18,17 @@ see-also:
   - "/keps/sig-apps/2232-suspend-jobs"
 
 # The target maturity stage in the current dev cycle for this KEP.
-stage: beta
+stage: stable
 
 # The most recent milestone for which work toward delivery of this KEP has been
 # done. This can be the current (upcoming) milestone, if it is being actively
 # worked on.
-latest-milestone: "v1.23"
+latest-milestone: "v1.27"
 
 # The milestone at which this feature was, or is targeted to be, at each stage.
 milestone:
   beta: "v1.23"
-  stable: "v1.25"
+  stable: "v1.27"
 
 # The following PRR answers are required at alpha release
 # List the feature gate name and the components for which it must be enabled