Skip to content

Commit f8ed259

Browse files
committed
Clarify more around the downgrade and feature disablement scenarios
1 parent a6a044e commit f8ed259

File tree

1 file changed

+11
-3
lines changed
  • keps/sig-scheduling/5194-reserved-for-workloads

1 file changed

+11
-3
lines changed

keps/sig-scheduling/5194-reserved-for-workloads/README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -485,9 +485,17 @@ this:
485485
leading to a situation where the claim will never be deallocated.
486486
- For new pods that gets scheduled, the scheduler will add pod references in the
487487
`ReservedFor` list, despite there being a non-pod reference here. So it ends up with
488-
both pod and non-pod references in the list. We need to make sure the system can
489-
handle this, as it might also happen as a result of disablement and the enablement
490-
of the feature.
488+
both pod and non-pod references in the list. We can manage both pod and non-pod
489+
references in the list by letting the workload controllers add the non-pod reference
490+
even if it sees pod references and making sure that the resourceclaim controller removes
491+
pod references even if there are non-pod references in the list. For deallocation, it is
492+
only safe when no pods are consuming the claim, so both workload and pod reference should
493+
be removed once that is true.
494+
495+
We will also provide explicit recommendations for how users can manage downgrades or
496+
disabling this feature. This means manually updating the references in the `ReservedFor` list
497+
to be pods rather than the reference to workload resources. We don't plan on providing
498+
automation for this.
491499

492500
### Version Skew Strategy
493501

0 commit comments

Comments
 (0)