From b3b2ce8e1771e376df5b1f7165943178d622e2ef Mon Sep 17 00:00:00 2001 From: kerthcet Date: Wed, 18 May 2022 21:50:22 +0800 Subject: [PATCH 1/4] Feat: graduate kube-scheduler component config to GA Signed-off-by: kerthcet --- .../785-scheduler-component-config-api/README.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/keps/sig-scheduling/785-scheduler-component-config-api/README.md b/keps/sig-scheduling/785-scheduler-component-config-api/README.md index 434b7fe8524..35403771d76 100644 --- a/keps/sig-scheduling/785-scheduler-component-config-api/README.md +++ b/keps/sig-scheduling/785-scheduler-component-config-api/README.md @@ -47,7 +47,8 @@ The kube-scheduler configuration API `kubescheduler.config.k8s.io` was in alpha for several releases. We graduated it to beta in 1.19 as `v1beta1`. We introduced -`v1beta2` and `v1beta3` in 1.22 and 1.23 respectively. +`v1beta2` and `v1beta3` in 1.22 and 1.23 respectively. We'd like to graduate it +to GA in `v1.25` and remove the support for `v1beta2` at the same time. ## Motivation @@ -105,6 +106,9 @@ The third iteration, `kubescheduler.config.k8s.io/v1beta3`, includes the followi - Remove `v1beta1` - Remove the legacy [policy config API](https://kubernetes.io/docs/reference/scheduling/policies/) +The fourth iteration, `kubescheduler.config.k8s.io/v1`, includes the following changes: + - Remove `v1beta2` + The main reason is that some plugins have "default" behavior without needing user inputs, whereas the above plugins are about user preferences, so should have more influence while making scheduling decisions. More information on the discussion can be found [here](https://github.com/kubernetes/kubernetes/issues/88174). @@ -219,6 +223,9 @@ N/A - No changes to plugins enabled by default. Only their weights would change. - Remove `v1beta1`. + When `v1` gets introduced: + - Remove `v1beta2`. + ### Monitoring requirements * **How can an operator determine if the feature is in use by workloads?** @@ -302,3 +309,4 @@ N/A - 2021-07-08: Introducing `v1beta2`. - 2021-08-06: Introducing `v1beta3`. - 2021-09-01: Remove `v1beta1` and the legacy policy config API. +- 2022-05-18: Introducing `v1` and remove `v1beta2`. From 4725039f925c4fcaeda3df905a1e8e2fcd41ea90 Mon Sep 17 00:00:00 2001 From: kerthcet Date: Thu, 19 May 2022 14:21:06 +0800 Subject: [PATCH 2/4] Move the doc to the right place Signed-off-by: kerthcet --- .../785-scheduler-component-config-api/README.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/keps/sig-scheduling/785-scheduler-component-config-api/README.md b/keps/sig-scheduling/785-scheduler-component-config-api/README.md index 35403771d76..b04e4b02b75 100644 --- a/keps/sig-scheduling/785-scheduler-component-config-api/README.md +++ b/keps/sig-scheduling/785-scheduler-component-config-api/README.md @@ -106,12 +106,13 @@ The third iteration, `kubescheduler.config.k8s.io/v1beta3`, includes the followi - Remove `v1beta1` - Remove the legacy [policy config API](https://kubernetes.io/docs/reference/scheduling/policies/) -The fourth iteration, `kubescheduler.config.k8s.io/v1`, includes the following changes: - - Remove `v1beta2` - The main reason is that some plugins have "default" behavior without needing user inputs, whereas the above plugins are about user preferences, so should have more influence while making scheduling decisions. More information on the discussion can be found [here](https://github.com/kubernetes/kubernetes/issues/88174). + +The fourth iteration, `kubescheduler.config.k8s.io/v1`, includes the following changes: + - Remove `v1beta2` + ### Risks and Mitigations The major risk is around the removal of the `unreserve` extension point. From acda4888c093d66098a2f58774745569a6e60ee5 Mon Sep 17 00:00:00 2001 From: kerthcet Date: Wed, 1 Jun 2022 08:39:01 +0800 Subject: [PATCH 3/4] Mark v2beta2 as deprecated instead of removing Signed-off-by: kerthcet --- .../785-scheduler-component-config-api/README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/keps/sig-scheduling/785-scheduler-component-config-api/README.md b/keps/sig-scheduling/785-scheduler-component-config-api/README.md index b04e4b02b75..b2017836c92 100644 --- a/keps/sig-scheduling/785-scheduler-component-config-api/README.md +++ b/keps/sig-scheduling/785-scheduler-component-config-api/README.md @@ -48,7 +48,8 @@ The kube-scheduler configuration API `kubescheduler.config.k8s.io` was in alpha for several releases. We graduated it to beta in 1.19 as `v1beta1`. We introduced `v1beta2` and `v1beta3` in 1.22 and 1.23 respectively. We'd like to graduate it -to GA in `v1.25` and remove the support for `v1beta2` at the same time. +to GA in `v1.25` and mark `v1beta2` as deprecated for not breaking existing users, +we'll remove the support of `v2beta2` in `v1.26`. ## Motivation @@ -111,7 +112,7 @@ about user preferences, so should have more influence while making scheduling de More information on the discussion can be found [here](https://github.com/kubernetes/kubernetes/issues/88174). The fourth iteration, `kubescheduler.config.k8s.io/v1`, includes the following changes: - - Remove `v1beta2` + - Mark `v1beta2` as deprecated ### Risks and Mitigations @@ -225,7 +226,7 @@ N/A - Remove `v1beta1`. When `v1` gets introduced: - - Remove `v1beta2`. + - Mark `v1beta2` as deprecated. ### Monitoring requirements @@ -310,4 +311,4 @@ N/A - 2021-07-08: Introducing `v1beta2`. - 2021-08-06: Introducing `v1beta3`. - 2021-09-01: Remove `v1beta1` and the legacy policy config API. -- 2022-05-18: Introducing `v1` and remove `v1beta2`. +- 2022-05-18: Introducing `v1` and mark `v1beta2` as deprecated. From 5c920af67d26a22579ba61ca2f0e86b1e8477656 Mon Sep 17 00:00:00 2001 From: kerthcet Date: Wed, 1 Jun 2022 13:38:51 +0800 Subject: [PATCH 4/4] resolve format problems Signed-off-by: kerthcet --- .../785-scheduler-component-config-api/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/keps/sig-scheduling/785-scheduler-component-config-api/README.md b/keps/sig-scheduling/785-scheduler-component-config-api/README.md index b2017836c92..993ba92655f 100644 --- a/keps/sig-scheduling/785-scheduler-component-config-api/README.md +++ b/keps/sig-scheduling/785-scheduler-component-config-api/README.md @@ -48,8 +48,8 @@ The kube-scheduler configuration API `kubescheduler.config.k8s.io` was in alpha for several releases. We graduated it to beta in 1.19 as `v1beta1`. We introduced `v1beta2` and `v1beta3` in 1.22 and 1.23 respectively. We'd like to graduate it -to GA in `v1.25` and mark `v1beta2` as deprecated for not breaking existing users, -we'll remove the support of `v2beta2` in `v1.26`. +to GA in 1.25 and mark `v1beta2` as deprecated to avoid breaking existing users, +we'll remove the support of `v1beta2` in 1.26. ## Motivation