Skip to content

Commit 2e25b63

Browse files
feat: support custom labels for internal service
This change allows configuring labels specifically for the internal service without affecting the main controller service, useful for external-dns configuration.
1 parent 8da3423 commit 2e25b63

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

charts/ingress-nginx/ci/controller-service-internal-values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,6 @@ controller:
1111
enabled: true
1212
annotations:
1313
service.beta.kubernetes.io/aws-load-balancer-internal: "true"
14+
labels:
15+
external-dns.alpha.kubernetes.io/hostname: internal.example.com
16+

charts/ingress-nginx/templates/controller-service-internal.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ metadata:
1212
{{- if .Values.controller.service.labels }}
1313
{{- toYaml .Values.controller.service.labels | nindent 4 }}
1414
{{- end }}
15+
{{- if .Values.controller.service.internal.labels }}
16+
{{- toYaml .Values.controller.service.internal.labels | nindent 4 }}
17+
{{- end }}
1518
name: {{ include "ingress-nginx.controller.fullname" . }}-internal
1619
namespace: {{ include "ingress-nginx.namespace" . }}
1720
spec:

charts/ingress-nginx/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ controller:
580580
# -- Type of the internal controller service.
581581
# Defaults to the value of `controller.service.type`.
582582
# Ref: https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types
583+
labels: {}
584+
# -- Type of the internal controller service.
583585
type: ""
584586
# -- Pre-defined cluster internal IP address of the internal controller service. Take care of collisions with existing services.
585587
# This value is immutable. Set once, it can not be changed without deleting and re-creating the service.

0 commit comments

Comments
 (0)