File tree Expand file tree Collapse file tree 2 files changed +7
-0
lines changed
internal/ingress/controller Expand file tree Collapse file tree 2 files changed +7
-0
lines changed Original file line number Diff line number Diff line change @@ -421,11 +421,15 @@ func (n *NGINXController) CheckIngress(ing *networking.Ingress) error {
421
421
return err
422
422
}
423
423
424
+ /* Deactivated to mitigate CVE-2025-1974
425
+ // TODO: Implement sandboxing so this test can be done safely
424
426
err = n.testTemplate(content)
425
427
if err != nil {
426
428
n.metricCollector.IncCheckErrorCount(ing.ObjectMeta.Namespace, ing.Name)
427
429
return err
428
430
}
431
+ */
432
+
429
433
n .metricCollector .IncCheckCount (ing .ObjectMeta .Namespace , ing .Name )
430
434
endCheck := time .Now ().UnixNano () / 1000000
431
435
n .metricCollector .SetAdmissionMetrics (
Original file line number Diff line number Diff line change @@ -250,6 +250,8 @@ func TestCheckIngress(t *testing.T) {
250
250
}
251
251
})
252
252
253
+ /* Deactivated to mitigate CVE-2025-1974
254
+ // TODO: Implement sandboxing so this test can be done safely
253
255
t.Run("When nginx test returns an error", func(t *testing.T) {
254
256
nginx.command = testNginxTestCommand{
255
257
t: t,
@@ -261,6 +263,7 @@ func TestCheckIngress(t *testing.T) {
261
263
t.Errorf("with a new ingress with an error, an error should be returned")
262
264
}
263
265
})
266
+ */
264
267
265
268
t .Run ("When the default annotation prefix is used despite an override" , func (t * testing.T ) {
266
269
defer func () {
You can’t perform that action at this time.
0 commit comments