Skip to content

Commit 8a66548

Browse files
feat: support custom labels for internal service
This change allows configuring labels specifically for the internal service without affecting the main controller service, useful for external-dns configuration.
1 parent 8da3423 commit 8a66548

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

charts/ingress-nginx/ci/controller-service-internal-values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,6 @@ controller:
1111
enabled: true
1212
annotations:
1313
service.beta.kubernetes.io/aws-load-balancer-internal: "true"
14+
labels:
15+
external-dns.alpha.kubernetes.io/hostname: internal.example.com
16+

charts/ingress-nginx/templates/controller-service-internal.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- if and .Values.controller.service.enabled .Values.controller.service.internal.enabled .Values.controller.service.internal.annotations -}}
1+
{{- if and .Values.controller.service.enabled .Values.controller.service.internal.enabled -}}
22
apiVersion: v1
33
kind: Service
44
metadata:
@@ -9,8 +9,8 @@ metadata:
99
labels:
1010
{{- include "ingress-nginx.labels" . | nindent 4 }}
1111
app.kubernetes.io/component: controller
12-
{{- if .Values.controller.service.labels }}
13-
{{- toYaml .Values.controller.service.labels | nindent 4 }}
12+
{{- if .Values.controller.service.internal.labels }}
13+
{{- toYaml .Values.controller.service.internal.labels | nindent 4 }}
1414
{{- end }}
1515
name: {{ include "ingress-nginx.controller.fullname" . }}-internal
1616
namespace: {{ include "ingress-nginx.namespace" . }}

charts/ingress-nginx/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,14 @@ controller:
2525
image:
2626
## Keep false as default for now!
2727
chroot: false
28+
service:
29+
internal:
30+
# Enable the internal service for ingress traffic
31+
enabled: false
32+
# -- Annotations to be added to internal service
33+
annotations: {}
34+
# -- Additional custom labels for internal service specifically, useful for external-dns configuration
35+
labels: {}
2836
# registry: registry.k8s.io
2937
image: ingress-nginx/controller
3038
## for backwards compatibility consider setting the full image url via the repository value below

0 commit comments

Comments
 (0)