Skip to content

Commit a86f7fc

Browse files
bugfix : fix --with-kubernetes not affect (#2759)
bugfix : fix --with-kubernetes config not effect bugfix : fix --with-kubernetes config not effect Signed-off-by: xuesongzuo@yunify.com <xuesongzuo@yunify.com>
1 parent 32aba62 commit a86f7fc

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

cmd/kk/app/options/builtin/add.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ func (o *AddNodeOptions) Complete(cmd *cobra.Command, args []string) (*kkcorev1.
102102

103103
// complete updates the configuration with container manager and kubernetes version settings
104104
func (o *AddNodeOptions) complete() error {
105-
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kube_version"); !ok {
106-
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kube_version"); err != nil {
105+
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kubernetes", "kube_version"); !ok {
106+
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kubernetes", "kube_version"); err != nil {
107107
return errors.Wrapf(err, "failed to set %q to config", "kube_version")
108108
}
109109
}

cmd/kk/app/options/builtin/create.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ func (o *CreateClusterOptions) Complete(cmd *cobra.Command, args []string) (*kkc
9595
}
9696

9797
func (o *CreateClusterOptions) completeConfig() error {
98-
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kube_version"); !ok {
99-
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kube_version"); err != nil {
98+
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kubernetes", "kube_version"); !ok {
99+
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kubernetes", "kube_version"); err != nil {
100100
return errors.Wrapf(err, "failed to set %q to config", "kube_version")
101101
}
102102
}

cmd/kk/app/options/builtin/delete.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ func (o *DeleteClusterOptions) Complete(cmd *cobra.Command, args []string) (*kkc
103103
// completeConfig updates the configuration with container manager settings
104104
func (o *DeleteClusterOptions) completeConfig() error {
105105
// If kube_version is not set in config, set it to the specified Kubernetes version
106-
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kube_version"); !ok {
107-
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kube_version"); err != nil {
106+
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kubernetes", "kube_version"); !ok {
107+
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kubernetes", "kube_version"); err != nil {
108108
return errors.Wrapf(err, "failed to set %q to config", "kube_version")
109109
}
110110
}
@@ -184,8 +184,8 @@ func (o *DeleteNodesOptions) Complete(cmd *cobra.Command, args []string) (*kkcor
184184
// completeConfig updates the configuration with container manager settings
185185
func (o *DeleteNodesOptions) completeConfig(nodes []string) error {
186186
// If kube_version is not set in config, set it to the specified Kubernetes version
187-
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kube_version"); !ok {
188-
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kube_version"); err != nil {
187+
if _, ok, _ := unstructured.NestedFieldNoCopy(o.CommonOptions.Config.Value(), "kubernetes", "kube_version"); !ok {
188+
if err := unstructured.SetNestedField(o.CommonOptions.Config.Value(), o.Kubernetes, "kubernetes", "kube_version"); err != nil {
189189
return errors.Wrapf(err, "failed to set %q to config", "kube_version")
190190
}
191191
}

0 commit comments

Comments
 (0)