Skip to content

Commit 5a344fe

Browse files
authored
Merge pull request #39 from kudulab/35-docker-compose-does-not-like-capital-letters
Fix #35 support running with docker-compose when the current directory contains upper case letters
2 parents 6e0a6b5 + 6d343af commit 5a344fe

26 files changed

+574
-242
lines changed

.circleci/config.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,22 +94,18 @@ jobs:
9494
- attach_workspace:
9595
at: ~/repo
9696
- run:
97-
command: /bin/bash -c "./tasks e2e ubuntu18"
97+
command: /bin/bash -c "./tasks e2e ubuntu"
9898
- run:
99-
command: /bin/bash -c "./tasks test_signals ubuntu18"
99+
command: /bin/bash -c "./tasks test_signals ubuntu"
100100

101101
test_images:
102102
executor: platform
103103
steps:
104104
- setup
105-
- run:
106-
command: sudo git clone https://github.com/bats-core/bats-core /opt/bats-core
107-
- run:
108-
command: sudo git clone https://github.com/bats-core/bats-assert /opt/bats-assert
109-
- run:
110-
command: sudo git clone https://github.com/bats-core/bats-support /opt/bats-support
111105
- attach_workspace:
112106
at: ~/repo
107+
- run:
108+
command: /bin/bash -c "cd image_scripts && sudo ./tasks install_bats"
113109
- run:
114110
command: /bin/bash -c "cd image_scripts && ./tasks build"
115111
- run:
@@ -153,5 +149,5 @@ commands:
153149
executors:
154150
platform:
155151
machine:
156-
image: ubuntu-2004:202101-01
152+
image: ubuntu-2204:2024.01.1
157153
working_directory: ~/repo

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,3 +141,5 @@ dmypy.json
141141

142142
test/test-files/custom-dir-env-var
143143
/ops/
144+
145+
dojo-signal-test-output

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
### 0.12.0 (2024-Feb-04)
2+
3+
* Compile Dojo using Golang 1.21.6 thanks to using Docker image kudulab/golang-dojo:2.1.0
4+
* Improve support for Docker-compose >2.
5+
* New versions of Docker-compose (e.g. 2.24.5) have different output of the `docker-compose ps` command (than the old versions of Docker-compose, e.g. 1.23.2). This was affecting Dojo as in Dojo was not aware that the containers were already created and running. This, in turn, was affecting the logging collection (the `--print-logs` options).
6+
* Also, the default docker containers in Docker-compose >2 contain this string `-default-` (with dashes), while the older versions of Docker-compose contained this string `_default_` (with underscores)
7+
* Fix https://github.com/kudulab/dojo/issues/35 - support the case when the current directory contains upper case letters and Docker-Compose >2 is run
8+
19
### 0.11.0 (2022-Feb-27)
210

311
* Compile Dojo using Golang 1.17.7 thanks to using Docker image kudulab/golang-dojo:2.0.0

Dojofile.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
DOJO_DOCKER_IMAGE=kudulab/golang-dojo:2.0.0
1+
DOJO_DOCKER_IMAGE=kudulab/golang-dojo:2.1.0
22
DOJO_DOCKER_OPTIONS="--security-opt seccomp:unconfined"

Dojofile.e2e-alpine

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
DOJO_DOCKER_IMAGE="kudulab/inception-dojo:alpine-dind-0.3.0"
1+
DOJO_DOCKER_IMAGE="kudulab/inception-dojo:alpine-0.6.1"
22
DOJO_DOCKER_OPTIONS="--privileged"

Dojofile.e2e-ubuntu

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
DOJO_DOCKER_IMAGE="kudulab/inception-dojo:ubuntu-0.6.1"
2+
DOJO_DOCKER_OPTIONS="--privileged"

Dojofile.e2e-ubuntu18

Lines changed: 0 additions & 2 deletions
This file was deleted.

Dojofile.gdojo

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# this is not a public image
2-
DOJO_DOCKER_IMAGE="kudulab/golang-gdojo:0.1.0"
2+
DOJO_DOCKER_IMAGE="kudulab/golang-gdojo:0.2.0"
33
DOJO_WORK_INNER="/dojo/work/src/dojo"
44
DOJO_DOCKER_OPTIONS="--security-opt seccomp:unconfined"
55

0 commit comments

Comments
 (0)