[Store][Bugfix] Fixed the problem of filling in the wrong TE endpoint

Co-authored-by: wanyue.wy <wanyue.wy@oceanbase.com>

Author: wanyue-wy

mooncake-store/include/client_service.h

@@ -513,6 +513,12 @@ class ClientService {
         return local_ip_ + ":" + std::to_string(te_port_);
     }
 
+    // The segment endpoint that the transfer engine registered with the
+    // metadata backend.
+    std::string te_endpoint_;
+    void initTeEndpoint();
+    const std::string& get_te_endpoint() const { return te_endpoint_; }
+
     const std::string metadata_connstring_;
     // For high availability
     MasterViewHelper master_view_helper_;

mooncake-store/src/centralized_client_service.cpp

@@ -151,6 +151,7 @@ ErrorCode CentralizedClientService::Init(
         LOG(INFO) << "Use existing transfer engine instance. Skip its "
                      "initialization.";
     }
+    initTeEndpoint();
 
     InitTransferSubmitter();
 
@@ -1639,14 +1640,7 @@ tl::expected<void, ErrorCode> CentralizedClientService::MountSegment(
     CentralizedSegmentExtraData extra;
     extra.base = reinterpret_cast<uintptr_t>(buffer);
 
-    // For P2P handshake mode, publish the actual transport endpoint that was
-    // negotiated by the transfer engine. Otherwise, keep the logical hostname
-    // so metadata backends (HTTP/etcd/redis) can resolve the segment by name.
-    if (metadata_connstring_ == P2PHANDSHAKE) {
-        extra.te_endpoint = transfer_engine_->getLocalIpAndPort();
-    } else {
-        extra.te_endpoint = local_endpoint();
-    }
+    extra.te_endpoint = get_te_endpoint();
     segment.extra = extra;
 
     auto mount_result = master_client_.MountSegment(segment);

mooncake-store/src/client_service.cpp

@@ -10,12 +10,25 @@
 #include <thread>
 
 #include "config.h"
+#include "transfer_engine.h"
 #include "types.h"
 #include "p2p_client_service.h"
 #include "centralized_client_service.h"
 
 namespace mooncake {
 
+void ClientService::initTeEndpoint() {
+    // For P2PHANDSHAKE the TE picks a random port and updates
+    // local_server_name_ accordingly, so getLocalIpAndPort() is authoritative.
+    // For HTTP/etcd/redis metadata the segment is published under the
+    // configured local_endpoint().
+    if (metadata_connstring_ == P2PHANDSHAKE) {
+        te_endpoint_ = transfer_engine_->getLocalIpAndPort();
+    } else {
+        te_endpoint_ = local_endpoint();
+    }
+}
+
 size_t ClientService::CalculateSliceSize(const std::vector<Slice>& slices) {
     size_t slice_size = 0;
     for (const auto& slice : slices) {

mooncake-store/src/p2p_client_service.cpp

@@ -95,6 +95,7 @@ ErrorCode P2PClientService::Init(const P2PClientConfig& config) {
         LOG(INFO) << "Use existing transfer engine instance. Skip its "
                      "initialization.";
     }
+    initTeEndpoint();
 
     // 3. Register with master BEFORE InitStorage, because InitStorage
     //    triggers TieredBackend::MountSegment which requires the client to
@@ -445,7 +446,7 @@ tl::expected<void, ErrorCode> P2PClientService::PutViaRoute(
             write_req.key = key;
             for (const auto& slice : slices) {
                 RemoteBufferDesc buf;
-                buf.segment_endpoint = transfer_engine_->getLocalIpAndPort();
+                buf.segment_endpoint = get_te_endpoint();
                 buf.addr = reinterpret_cast<uintptr_t>(slice.ptr);
                 buf.size = slice.size;
                 write_req.src_buffers.push_back(buf);
@@ -894,7 +895,7 @@ tl::expected<void, ErrorCode> P2PClientService::GetRemoteViaRoute(
             read_req.key = key;
             for (const auto& slice : slices) {
                 RemoteBufferDesc buf;
-                buf.segment_endpoint = transfer_engine_->getLocalIpAndPort();
+                buf.segment_endpoint = get_te_endpoint();
                 buf.addr = reinterpret_cast<uintptr_t>(slice.ptr);
                 buf.size = slice.size;
                 read_req.dest_buffers.push_back(buf);