Skip to content

Commit 891f05e

Browse files
Disabled validateField call during reset. Upgrade version to 1.0.2. Updated initial values in example app
1 parent 62d80ed commit 891f05e

5 files changed

Lines changed: 10 additions & 5 deletions

File tree

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,3 +233,8 @@ form.handleSubmit((values: T) => void): (values: T) => void
233233
## Contributors
234234

235235
- [Kwame Opare Asiedu](https://github.com/kwameopareasiedu)
236+
237+
## Changelog
238+
239+
- 1.0.2 (Current)
240+
- Disabled call to `form.validateField` on `form.reset` to avoid errors on form reset

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default function App() {
99
const form = new Form({
1010
initialValues: {
1111
input: "",
12-
range: 50,
12+
range: 30,
1313
select: "",
1414
radio: "",
1515
checkbox: false

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vanjs-form",
3-
"version": "1.0.1",
3+
"version": "1.0.2",
44
"description": "Fully typed form state management library (with validation) for VanJS",
55
"repository": "https://github.com/kwameopareasiedu/vanjs-form",
66
"homepage": "https://github.com/kwameopareasiedu/vanjs-form",

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export class Form<T extends Record<string, unknown>> {
142142
field.touched.val = false;
143143
field.error.val = "";
144144

145-
if (this.validationMode === "oninput") this.validateField(name);
145+
// if (this.validationMode === "oninput") this.validateField(name);
146146
}
147147
} else {
148148
for (const key in this.fields) {
@@ -151,7 +151,7 @@ export class Form<T extends Record<string, unknown>> {
151151
field.touched.val = false;
152152
field.error.val = "";
153153

154-
if (this.validationMode === "oninput") this.validateField(key);
154+
// if (this.validationMode === "oninput") this.validateField(key);
155155
}
156156
}
157157
}

0 commit comments

Comments
 (0)