fix: reference history format

Author: c121914yu

docSite/content/zh-cn/docs/development/upgrading/4101.md

@@ -18,4 +18,5 @@ weight: 784
 ## 🐛 修复
 
 1. 搜索类型系统工具无法正常显示
-2. 部分系统工具向下兼容问题
+2. 部分系统工具向下兼容问题
+3. AI 节点，手动选择历史记录时，会导致 system 记录重复。

packages/service/core/workflow/dispatch/utils.ts

@@ -83,16 +83,14 @@ export const filterToolNodeIdByEdges = ({
 
 export const getHistories = (history?: ChatItemType[] | number, histories: ChatItemType[] = []) => {
   if (!history) return [];
+  // Select reference history
+  if (Array.isArray(history)) return history;
 
+  // history is number
   const systemHistoryIndex = histories.findIndex((item) => item.obj !== ChatRoleEnum.System);
   const systemHistories = histories.slice(0, systemHistoryIndex);
   const chatHistories = histories.slice(systemHistoryIndex);
-
-  const filterHistories = (() => {
-    if (typeof history === 'number') return chatHistories.slice(-(history * 2));
-    if (Array.isArray(history)) return history;
-    return [];
-  })();
+  const filterHistories = chatHistories.slice(-(history * 2));
 
   return [...systemHistories, ...filterHistories];
 };

test/cases/function/packages/service/core/app/workflow/dispatch/utils.test.ts

@@ -0,0 +1,106 @@
+import { describe, expect, it } from 'vitest';
+import { getHistories } from '@fastgpt/service/core/workflow/dispatch/utils';
+import { ChatItemValueTypeEnum, ChatRoleEnum } from '@fastgpt/global/core/chat/constants';
+import type { ChatItemType } from '@fastgpt/global/core/chat/type';
+
+describe('getHistories test', async () => {
+  const MockHistories: ChatItemType[] = [
+    {
+      obj: ChatRoleEnum.System,
+      value: [
+        {
+          type: ChatItemValueTypeEnum.text,
+          text: {
+            content: '你好'
+          }
+        }
+      ]
+    },
+    {
+      obj: ChatRoleEnum.Human,
+      value: [
+        {
+          type: ChatItemValueTypeEnum.text,
+          text: {
+            content: '你好'
+          }
+        }
+      ]
+    },
+    {
+      obj: ChatRoleEnum.AI,
+      value: [
+        {
+          type: ChatItemValueTypeEnum.text,
+          text: {
+            content: '你好2'
+          }
+        }
+      ]
+    },
+    {
+      obj: ChatRoleEnum.Human,
+      value: [
+        {
+          type: ChatItemValueTypeEnum.text,
+          text: {
+            content: '你好3'
+          }
+        }
+      ]
+    },
+    {
+      obj: ChatRoleEnum.AI,
+      value: [
+        {
+          type: ChatItemValueTypeEnum.text,
+          text: {
+            content: '你好4'
+          }
+        }
+      ]
+    }
+  ];
+
+  it('getHistories', async () => {
+    // Number
+    expect(getHistories(1, MockHistories)).toEqual([
+      ...MockHistories.slice(0, 1),
+      ...MockHistories.slice(-2)
+    ]);
+    expect(getHistories(2, MockHistories)).toEqual([...MockHistories.slice(0)]);
+    expect(getHistories(4, MockHistories)).toEqual([...MockHistories.slice(0)]);
+
+    // Array
+    expect(
+      getHistories(
+        [
+          {
+            obj: ChatRoleEnum.Human,
+            value: [
+              {
+                type: ChatItemValueTypeEnum.text,
+                text: {
+                  content: '你好'
+                }
+              }
+            ]
+          }
+        ],
+        MockHistories
+      )
+    ).toEqual([
+      {
+        obj: ChatRoleEnum.Human,
+        value: [
+          {
+            type: ChatItemValueTypeEnum.text,
+            text: {
+              content: '你好'
+            }
+          }
+        ]
+      }
+    ]);
+  });
+});