Merge pull request #197 from laminas/renovate/lock-file-maintenance

chore(deps): lock file maintenance

Author: Ocramius

.laminas-ci.json

@@ -1,5 +1,8 @@
 {
     "extensions": [
         "bcmath"
+    ],
+    "ini": [
+        "memory_limit=-1"
     ]
 }

bin/console.php

@@ -107,7 +107,6 @@ static function (int $errorCode, string $message = '', string $file = '', int $l
         $logger
     );
 
-    /** @psalm-suppress DeprecatedClass */
     $application = new Application(Versions::rootPackageName(), Versions::getVersion('laminas/automatic-releases'));
 
     $application->addCommands([

composer.lock

@@ -1,9 +1,10 @@
 <?xml version="1.0"?>
 <psalm
-    totallyTyped="true"
+    errorLevel="1"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+    findUnusedPsalmSuppress="true"
 >
     <projectFiles>
         <directory name="bin"/>

psalm.xml.dist

@@ -2,5 +2,11 @@
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
   "extends": [
     "local>laminas/.github:renovate-config"
+  ],
+  "packageRules": [
+    {
+      "matchDepTypes": ["require"],
+      "rangeStrategy": "bump"
+    }
   ]
 }

renovate.json

@@ -55,9 +55,7 @@ public function __construct(
             $changelogEntry = clone $changelogEntry;
         }
 
-        $this->contents = $contents;
-
-        /** @psalm-suppress ImpurePropertyAssignment */
+        $this->contents       = $contents;
         $this->changelogEntry = $changelogEntry;
     }
 
@@ -69,6 +67,7 @@ public function contents(): string
         return $this->contents;
     }
 
+    /** @throws RuntimeException if release notes already exist in both merged objects. */
     public function merge(self $next): self
     {
         if ($this->changelogEntry && $next->changelogEntry) {
@@ -83,9 +82,8 @@ public function merge(self $next): self
             $changelogEntry = clone $changelogEntry;
         }
 
-        $merged            = clone $this;
-        $merged->contents .= self::CONCATENATION_STRING . $next->contents;
-        /** @psalm-suppress ImpurePropertyAssignment */
+        $merged                 = clone $this;
+        $merged->contents      .= self::CONCATENATION_STRING . $next->contents;
         $merged->changelogEntry = $changelogEntry;
 
         return $merged;

src/Changelog/ChangelogReleaseNotes.php

@@ -27,8 +27,6 @@ final class IssueOrPullRequest
     /**
      * @psalm-param non-empty-string $title
      * @psalm-param list<Label> $labels
-     *
-     * @psalm-suppress ImpurePropertyAssignment {@see UriInterface} is pure
      */
     private function __construct(
         int $number,

src/Github/Api/GraphQL/Query/GetMilestoneChangelog/Response/IssueOrPullRequest.php

@@ -22,8 +22,6 @@ final class Label
     /**
      * @psalm-param non-empty-string $colour
      * @psalm-param non-empty-string $name
-     *
-     * @psalm-suppress ImpurePropertyAssignment {@see UriInterface} is pure
      */
     private function __construct(
         string $colour,

src/Github/Api/GraphQL/Query/GetMilestoneChangelog/Response/Label.php

@@ -30,8 +30,6 @@ final class Milestone
      * @param array<int, IssueOrPullRequest> $entries
      * @psalm-param non-empty-string $title
      * @psalm-param list<IssueOrPullRequest> $entries
-     *
-     * @psalm-suppress ImpurePropertyAssignment {@see UriInterface} is pure
      */
     private function __construct(
         int $number,

src/Github/Api/GraphQL/Query/GetMilestoneChangelog/Response/Milestone.php

@@ -233,4 +233,37 @@ public function testWillNotSwitchDefaultBranchIfNoBranchesExist(): void
             $output->fetch()
         );
     }
+
+    public function testWillRefuseToOperateWhenNotGivenAGitWorkingDirectory(): void
+    {
+        $workspace = Filesystem\create_temporary_file(Env\temp_dir(), 'workspace');
+
+        Filesystem\delete_file($workspace);
+        Filesystem\create_directory($workspace);
+
+        $this->variables->method('githubWorkspacePath')
+            ->willReturn($workspace);
+
+        $this->loadEvent->method('__invoke')
+            ->willReturn($this->event);
+
+        $this->fetch->expects(self::never())
+            ->method('__invoke');
+
+        $this->getMergeTargets->expects(self::never())
+            ->method('__invoke');
+
+        $this->push->expects(self::never())
+            ->method('__invoke');
+
+        $this->bumpChangelogVersion->expects(self::never())
+            ->method('__invoke');
+
+        $this->setDefaultBranch->expects(self::never())
+            ->method('__invoke');
+
+        $this->expectExceptionMessage('Workspace is not a GIT repository.');
+
+        $this->command->run(new ArrayInput([]), new NullOutput());
+    }
 }