Merge pull request #116 from lcobucci/fix-version-comparison

Fix version comparison algorithm

Author: Ocramius

src/Git/Value/SemVerVersion.php

@@ -86,6 +86,19 @@ public function isNewMajorRelease(): bool
 
     public function lessThanEqual(self $other): bool
     {
-        return $this->fullReleaseName() <= $other->fullReleaseName();
+        return $this->compare($other) <= 0;
+    }
+
+    private function compare(self $other): int
+    {
+        $comparison = $this->major <=> $other->major;
+
+        if ($comparison !== 0) {
+            return $comparison;
+        }
+
+        $comparison = $this->minor <=> $other->minor;
+
+        return $comparison !== 0 ? $comparison : $this->patch <=> $other->patch;
     }
 }

test/unit/Git/Value/SemVerVersionTest.php

@@ -188,6 +188,12 @@ public function lessThanEqualProvider(): array
             ['0.1.1', '0.1.0', false],
             ['2.0.0', '1.0.0', false],
             ['1.0.0', '2.0.0', true],
+            ['1.10.0', '1.9.0', false],
+            ['1.9.0', '1.10.0', true],
+            ['1.0.10', '1.0.9', false],
+            ['1.0.9', '1.0.10', true],
+            ['10.0.0', '9.0.0', false],
+            ['9.0.0', '10.0.0', true],
         ];
     }