Skip to content

Commit aa2ce05

Browse files
authored
Merge pull request #247 from gsteel/ci-fixes
Ci fixes
2 parents 68862e5 + 3c72cfe commit aa2ce05

File tree

9 files changed

+720
-631
lines changed

9 files changed

+720
-631
lines changed

README.md

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@
44
[![Psalm coverage](https://shepherd.dev/github/laminas/automatic-releases/coverage.svg?)](https://shepherd.dev/github/laminas/automatic-releases)
55

66
> ## 🇷🇺 Русским гражданам
7-
>
7+
>
88
> Мы, участники Laminas, родились и живем в разных странах. У многих из нас есть друзья, родственники и коллеги как в России, так и в Украине. Некоторые из нас родились в России. Некоторые из нас живут в России. У некоторых бабушки и дедушки сражались с фашистами во Второй мировой войне. Здесь никто не поддерживает фашизм.
9-
>
9+
>
1010
> У одного из нас есть украинская родственница, которая спаслась из дома вместе с сыном. Поезд задержался из-за бомбежки на дороге впереди. У нас есть друзья, которые прячутся в бомбоубежищах. Мы с тревогой ждем весточки от них после воздушных налетов, которые беспорядочно наносят удары и попадают по больницам, школам, детским садам и домам. Мы не берем это из каких-либо СМИ. Мы наблюдаем это напрямую.
11-
>
11+
>
1212
> Вы доверяете нам достаточно, чтоб использовать наши программы, и мы просим вас довериться нам вновь. Мы нуждаемся в помощи. Выходите и протестуйте против этой бесполезной войны. Остановите кровопролитие. Скажите "Нет войне!"
13-
>
13+
>
1414
> ## 🇺🇸 To Citizens of Russia
15-
>
15+
>
1616
> We at Laminas come from all over the world. Many of us have friends, family and colleagues in both Russia and Ukraine. Some of us were born in Russia. Some of us currently live in Russia. Some have grandparents who fought Nazis in World War II. Nobody here supports fascism.
17-
>
17+
>
1818
> One team member has a Ukrainian relative who fled her home with her son. The train was delayed due to bombing on the road ahead. We have friends who are hiding in bomb shelters. We anxiously follow up on them after the air raids, which indiscriminately fire at hospitals, schools, kindergartens and houses. We're not taking this from any media. These are our actual experiences.
19-
>
19+
>
2020
> You trust us enough to use our software. We ask that you trust us to say the truth on this. We need your help. Go out and protest this unnecessary war. Stop the bloodshed. Say "stop the war!"
2121
2222
This project is a [Github Action](https://github.com/features/actions) that allows
@@ -78,13 +78,14 @@ Next export the new sub key:
7878
```bash
7979
gpg --output private.key --armor --export-secret-subkeys "<SubKey ID>!"
8080
```
81+
8182
This will be exported to the file `private.key`.
8283
The `!` at the end is important as it limits the export to just the sub key
8384

84-
**Delete the file once you are done and don't share it with anyone else**
85+
**Delete the file once you are done** and don't share it with anyone else
8586

8687
If your master key is password protected, you will need to remove the password from the subkey before you can add it into github settings.
87-
You can skip this if your master key is not password protected.
88+
You can skip this if your master key is not password protected.
8889

8990
To remove the password from the subkey, create an ephemeral gpg home directory:
9091

@@ -143,7 +144,7 @@ To generate a new GPG key use the following command:
143144
gpg2 --full-generate-key
144145
```
145146

146-
Pick option 4, then type `4096` for key size, select your desired expiry.
147+
Pick option 4, then type `4096` for key size, select your desired expiry.
147148
Fill out the user information and leave the password blank.
148149

149150
Once generated it will output something like `gpg: key <Key ID> marked as ultimately trusted`. Take a note of this Key Id to use in the next step.
@@ -154,7 +155,7 @@ Now output the key to the file `private.key` in the correct format to put into t
154155
gpg --output private.key --armor --export-secret-key <Key ID>
155156
```
156157

157-
**Delete the file once you are done and don't share it with anyone else**
158+
**Delete the file once you are done** and don't share it with anyone else
158159

159160
Optionally, you can export the corresponding public key to the file `public.key`:
160161

@@ -171,15 +172,15 @@ Assuming your project has Github Actions enabled, each time you [**close**](http
171172
a [**milestone**](https://docs.github.com/en/github/managing-your-work-on-github/creating-and-editing-milestones-for-issues-and-pull-requests),
172173
this action will perform all following steps (or stop with an error):
173174

174-
1. determine if all issues and pull requests associated with this milestone are closed
175-
2. determine if the milestone is named with the SemVer `x.y.z` format
176-
3. create a changelog by looking at the milestone description and associated issues and pull requests
177-
4. select branch `x.y.z` for the release (e.g. `1.1.x` for a `1.1.0` release)
178-
5. create a tag named `x.y.z` on the selected branch, with the generated changelog
179-
6. publish a release named `x.y.z`, with the generated tag and changelog
180-
7. create (if applicable), a pull request from the selected branch to the next release branch
181-
8. create (if necessary) a "next minor" release branch `x.y+1.z`
182-
9. switch default repository branch to newest release branch
175+
1. determine if all issues and pull requests associated with this milestone are closed
176+
2. determine if the milestone is named with the SemVer `x.y.z` format
177+
3. create a changelog by looking at the milestone description and associated issues and pull requests
178+
4. select branch `x.y.z` for the release (e.g. `1.1.x` for a `1.1.0` release)
179+
5. create a tag named `x.y.z` on the selected branch, with the generated changelog
180+
6. publish a release named `x.y.z`, with the generated tag and changelog
181+
7. create (if applicable), a pull request from the selected branch to the next release branch
182+
8. create (if necessary) a "next minor" release branch `x.y+1.z`
183+
9. switch default repository branch to newest release branch
183184

184185
Please read the [`feature/`](./feature) specification for more detailed scenarios on how the tool is supposed
185186
to operate.
@@ -189,7 +190,7 @@ to operate.
189190
In this model we operate with release branches (e.g. `1.0.x`, `1.1.x`, `1.2.x`).
190191
This provides a lot of flexibility whilst keeping a single workflow.
191192

192-
![](./docs/branching-model.svg)
193+
![Branching model visualisation](./docs/branching-model.svg)
193194

194195
### Working on new features
195196

@@ -218,7 +219,7 @@ default branch. This ensures that all release branches are up-to-date and will n
218219
has already been fixed. Merge-up branches are automatically created but needs to be merged manually into
219220
the targeted branch.
220221

221-
**Example**
222+
#### Example
222223

223224
Let's say we've released the versions `1.0.0` and `1.1.0`.
224225
New features are being developed on `1.2.x`.

bin/console.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
use ChangelogGenerator\GitHubOAuthToken;
99
use DateTimeZone;
1010
use ErrorException;
11-
use Http\Discovery\HttpClientDiscovery;
1211
use Http\Discovery\Psr17FactoryDiscovery;
12+
use Http\Discovery\Psr18ClientDiscovery;
1313
use Laminas\AutomaticReleases\Application\Command\BumpChangelogForReleaseBranch;
1414
use Laminas\AutomaticReleases\Application\Command\CreateMergeUpPullRequest;
1515
use Laminas\AutomaticReleases\Application\Command\CreateMilestones;
@@ -77,7 +77,7 @@ static function (int $errorCode, string $message = '', string $file = '', int $l
7777
$fetch = new FetchAndSetCurrentUserByReplacingCurrentOriginRemote($variables);
7878
$getCandidateBranches = new GetMergeTargetCandidateBranchesFromRemoteBranches();
7979
$makeRequests = Psr17FactoryDiscovery::findRequestFactory();
80-
$httpClient = new LoggingHttpClient(HttpClientDiscovery::find(), $logger);
80+
$httpClient = new LoggingHttpClient(Psr18ClientDiscovery::find(), $logger);
8181
$githubToken = $variables->githubToken();
8282
$getMilestone = new GetMilestoneFirst100IssuesAndPullRequests(new RunGraphQLQuery(
8383
$makeRequests,

composer.json

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,35 +5,36 @@
55
"license": "BSD-3-Clause",
66
"require": {
77
"php": "~8.2.0",
8-
"azjezz/psl": "^2.4.1",
8+
"azjezz/psl": "^2.7.0",
99
"jwage/changelog-generator": "^1.4.0",
10-
"laminas/laminas-diactoros": "^2.24.0",
11-
"lcobucci/clock": "^3.0.0",
12-
"monolog/monolog": "^3.3.1",
10+
"laminas/laminas-diactoros": "^2.25.2",
11+
"lcobucci/clock": "^3.1.0",
12+
"monolog/monolog": "^3.4.0",
1313
"ocramius/package-versions": "^2.7.0",
1414
"phly/keep-a-changelog": "^2.12.1",
15-
"php-http/curl-client": "^2.2.1",
16-
"php-http/discovery": "^1.14.3",
17-
"php-http/httplug": "^2.3.0",
18-
"psr/http-client": "^1.0.1",
19-
"psr/http-message": "^1.0.1",
15+
"php-http/curl-client": "^2.3.0",
16+
"php-http/discovery": "^1.19.1",
17+
"php-http/httplug": "^2.4.0",
18+
"psr/http-client": "^1.0.2",
19+
"psr/http-message": "^1.1",
2020
"psr/log": "^3.0.0",
21-
"symfony/console": "^6.2.5"
21+
"symfony/console": "^6.3.4"
2222
},
2323
"require-dev": {
24-
"doctrine/coding-standard": "^11.0.0",
24+
"doctrine/coding-standard": "^11.1.0",
2525
"php-standard-library/psalm-plugin": "^2.2.1",
26-
"phpunit/phpunit": "^9.5.27",
26+
"phpunit/phpunit": "^9.6.12",
2727
"psalm/plugin-phpunit": "^0.18.4",
28-
"roave/infection-static-analysis-plugin": "^1.26.0",
29-
"squizlabs/php_codesniffer": "^3.7.1",
30-
"vimeo/psalm": "^5.3.0"
28+
"roave/infection-static-analysis-plugin": "^1.32.0",
29+
"squizlabs/php_codesniffer": "^3.7.2",
30+
"vimeo/psalm": "^5.15.0"
3131
},
3232
"config": {
3333
"sort-packages": true,
3434
"allow-plugins": {
3535
"infection/extension-installer": true,
36-
"dealerdirect/phpcodesniffer-composer-installer": true
36+
"dealerdirect/phpcodesniffer-composer-installer": true,
37+
"php-http/discovery": false
3738
}
3839
},
3940
"autoload": {

0 commit comments

Comments
 (0)