Improve mile stone failed detection

Signed-off-by: Geert Eltink <[email protected]>

Author: geerteltink

src/Application/Command/CreateMilestones.php

@@ -8,6 +8,7 @@
 use Laminas\AutomaticReleases\Git\Value\SemVerVersion;
 use Laminas\AutomaticReleases\Github\Api\GraphQL\Query\GetGithubMilestone;
 use Laminas\AutomaticReleases\Github\Api\V3\CreateMilestone;
+use Laminas\AutomaticReleases\Github\Api\V3\CreateMilestoneFailed;
 use Laminas\AutomaticReleases\Github\Event\Factory\LoadCurrentGithubEvent;
 use Laminas\AutomaticReleases\Github\Value\RepositoryName;
 use Symfony\Component\Console\Command\Command;
@@ -41,19 +42,19 @@ public function execute(InputInterface $input, OutputInterface $output): int
 
         $milestone->assertAllIssuesAreClosed();
 
-        $this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextPatch());
-        $this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextMinor());
-        $this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextMajor());
+        $this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextPatch(), $output);
+        $this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextMinor(), $output);
+        $this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextMajor(), $output);
 
         return 0;
     }
 
-    private function createMilestoneIfNotExists(RepositoryName $repositoryName, SemVerVersion $version): bool
+    private function createMilestoneIfNotExists(RepositoryName $repositoryName, SemVerVersion $version, OutputInterface $output): bool
     {
         try {
             ($this->createMilestone)($repositoryName, $version->nextPatch());
-        } catch (InvalidArgumentException $e) {
-            // Log that the milestone exists?
+        } catch (CreateMilestoneFailed $e) {
+            $output->writeln($e->getMessage());
             return false;
         }
 

src/Github/Api/V3/CreateMilestoneFailed.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Laminas\AutomaticReleases\Github\Api\V3;
+
+use RuntimeException;
+
+class CreateMilestoneFailed extends RuntimeException
+{
+    public static function forVersion(string $version, string $error): self
+    {
+        return new self(sprintf('Milestone "%s" creation failed: %s', $version, $error));
+    }
+}

src/Github/Api/V3/CreateMilestoneThroughApiCall.php

@@ -77,11 +77,13 @@ public function __invoke(
             ->getBody()
             ->__toString();
 
-        Assert::greaterThanEq($response->getStatusCode(), 200);
-        Assert::lessThanEq($response->getStatusCode(), 299);
+        if ($response->getStatusCode() !== 201) {
+            throw CreateMilestoneFailed::forVersion($version->fullReleaseName(), $responseBody);
+        }
 
-        $responseData = json_decode($responseBody, true);
+        Assert::eq($response->getStatusCode(), 201);
 
+        $responseData = json_decode($responseBody, true);
         Assert::isMap($responseData);
         Assert::keyExists($responseData, 'html_url');
         Assert::stringNotEmpty($responseData['html_url']);