Merge pull request #27 from boesing/feature/use-empty-command-for-no-check

feat: use empty command for no check

Author: weierophinney

README.md

@@ -61,10 +61,10 @@ It spits out a single output, "matrix", which is a JSON string in the following
       "name": "(string) Name of the check being run",
       "operatingSystem": "(string) Name of the OS the job should be run on (generally ubuntu-latest)",
       "action": "(string) GHA to run the step on; currently ignored, as GHA does not support dynamic action selection",
-      "job": "(string) JSON object detailing the job (more on this later)",
-    },
+      "job": "(string) JSON object detailing the job (more on this later)"
+    }
   ],
-  "exclude: [
+  "exclude": [
     {
     }
   ]
@@ -88,7 +88,7 @@ It will have the following elements, but is not restricted to them:
     "php.ini directives, one per element; e.g. 'memory_limit=-1'",
   ],
   "dependencies": "dependencies to test against; one of lowest, locked, latest",
-  "command": "command to run to perform the check",
+  "command": "command to run to perform the check"
 }
 ```
 
@@ -99,19 +99,19 @@ The package can include a configuration file in its root, `.laminas-ci.json`, wh
 ```json
 {
   "extensions": [
-    "extension names to install",
+    "extension names to install"
   ],
   "ini": [
-    "php.ini directives",
+    "php.ini directives"
   ],
   "checks": [
     {
-    },
+    }
   ],
   "additional_checks": [
     {
-    },
-  ]
+    }
+  ],
   "exclude": [
     {
     }
@@ -142,15 +142,15 @@ In each case, it MUST have the structure as noted above:
   "extensions": [
     "OPTIONAL array of strings",
     "Each element represents an extension to install",
-    "Names are from the Sury PHP repository, minus the php{VERSION}- prefix",
+    "Names are from the Sury PHP repository, minus the php{VERSION}- prefix"
   ],
   "ini": [
     "OPTIONAL array of strings",
     "Each element respresents one php.ini directive",
-    "e.g. 'memory_limit=-1'",
+    "e.g. 'memory_limit=-1'"
   ],
   "dependencies": "dependencies to test against; one of lowest, locked, latest",
-  "command": "command to run to perform the check",
+  "command": "command to run to perform the check"
 }
 ```
 

src/command.js

@@ -10,8 +10,8 @@ export class Command {
     /**
      * @param {String} command
      * @param {String} php
-     * @param {Array} extensions
-     * @param {Array} ini
+     * @param {Array<String>} extensions
+     * @param {Array<String>} ini
      * @param {String} dependencies
      */
     constructor(command, php, extensions, ini, dependencies) {

src/create-jobs.js

@@ -65,7 +65,7 @@ const createNoOpJob = function (config) {
     return [new Job(
         'No checks',
         JSON.stringify(new Command(
-            "echo 'No checks discovered'",
+            "",
             config.stable_version,
             [],
             [],