Skip to content

Commit ef05689

Browse files
committed
qa: add debug logging on why a job might not be excluded
Signed-off-by: Maximilian Bösing <[email protected]>
1 parent c6f9387 commit ef05689

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/config/app.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ function isJobExcludedByDeprecatedCommandName(job: Job, exclusions: JobToExclude
240240
);
241241
}
242242

243-
function isJobExcludedByConfiguration(job: Job, exclude: JobToExcludeFromFile, config: Config): boolean {
243+
function isJobExcludedByConfiguration(job: Job, exclude: JobToExcludeFromFile, config: Config, logger: Logger): boolean {
244244
const jobName = isJobFromTool(job) ? job.tool.name : job.name;
245245

246246
if (jobName !== exclude.name) {
@@ -251,21 +251,26 @@ function isJobExcludedByConfiguration(job: Job, exclude: JobToExcludeFromFile, c
251251
const dependenciesToExclude = exclude.dependencies ?? WILDCARD_ALIAS;
252252

253253
if (!isAnyPhpVersionType(phpVersionToExclude)) {
254+
const nonExcludedPhpVersionDebugMessage = `Job with name ${ jobName } is not matching exclusion rule with name ${ exclude.name } due to non-excluded php version.`;
254255
if (isLowestPhpVersionType(phpVersionToExclude) && job.job.php !== config.minimumPhpVersion) {
256+
logger.debug(nonExcludedPhpVersionDebugMessage);
255257
return false;
256258
}
257259

258260
if (isLatestPhpVersionType(phpVersionToExclude) && job.job.php !== config.latestPhpVersion) {
261+
logger.debug(nonExcludedPhpVersionDebugMessage);
259262
return false;
260263
}
261264

262265
if (phpVersionToExclude !== job.job.php) {
266+
logger.debug(nonExcludedPhpVersionDebugMessage);
263267
return false;
264268
}
265269
}
266270

267271
if (!isAnyComposerDependencySet(dependenciesToExclude)) {
268272
if (dependenciesToExclude !== job.job.composerDependencySet) {
273+
logger.debug(`Job with name ${ jobName } is not matching exclusion rule with name ${ exclude.name } due to non-excluded Composer dependencies.`);
269274
return false;
270275
}
271276
}
@@ -278,7 +283,7 @@ function isJobExcluded(job: Job, exclusions: JobToExcludeFromFile[], config: Con
278283
return false;
279284
}
280285

281-
if (exclusions.some((exclude) => isJobExcludedByConfiguration(job, exclude, config))) {
286+
if (exclusions.some((exclude) => isJobExcludedByConfiguration(job, exclude, config, logger))) {
282287
logger.info(`Job with name ${ job.name } is excluded due to application config.`);
283288

284289
return true;

0 commit comments

Comments
 (0)