Skip to content

Commit ef1e1f9

Browse files
committed
qa: replace Dockerfile node check with a dedicated job package-lock-up-to-date
That new job uses `package-lock-utd` package to verify `package-lock.json` is up2date with what `package.json` requires. Signed-off-by: Maximilian Bösing <[email protected]>
1 parent bf9f170 commit ef1e1f9

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,13 @@ jobs:
154154
run: "npm ci"
155155
- name: Run Jest
156156
run: "npm run test"
157+
158+
package-lock-up-to-date:
159+
runs-on: "ubuntu-latest"
160+
steps:
161+
- uses: "actions/checkout@v4"
162+
- uses: "actions/setup-node@v4"
163+
with:
164+
check-latest: true
165+
- name: "Check package-lock.json is up2date"
166+
run: "npx --yes package-lock-utd"

Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ COPY package*.json ./
66
COPY tsconfig.json ./
77
COPY webpack.config.ts ./
88
RUN npm ci
9-
RUN apk add --no-cache jq && npx semver -r $(jq -r '.packages."".engines.node' package-lock.json) $(node -v) || (echo "ERROR: package-lock.json is not synchronized with Dockerfile node version." && exit 1)
109
COPY ./src ./src
1110
RUN npm run build
1211

0 commit comments

Comments
 (0)