qa: rename targetReference to baseReference as it is more clear

Signed-off-by: Maximilian Bösing <[email protected]>

Author: boesing

src/config/app.spec.ts

@@ -57,7 +57,7 @@ describe('config/app', () => {
                 ignorePhpPlatformRequirements : {},
                 additionalComposerArguments   : [],
                 backwardCompatibilityCheck    : false,
-                targetReference               : null,
+                baseReference                 : null,
             });
         });
 
@@ -87,7 +87,7 @@ describe('config/app', () => {
                 ignorePhpPlatformRequirements : {},
                 additionalComposerArguments   : [],
                 backwardCompatibilityCheck    : true,
-                targetReference               : '1111222233334444aaaabbbbccccdddd',
+                baseReference                 : '1111222233334444aaaabbbbccccdddd',
             });
 
             process.env = environment;

src/config/app.ts

@@ -86,7 +86,7 @@ export interface Config {
     readonly ignorePhpPlatformRequirements: IgnorePhpPlatformRequirements;
     readonly additionalComposerArguments: string[];
     readonly backwardCompatibilityCheck: boolean;
-    readonly targetReference: string|null;
+    readonly baseReference: string|null;
 }
 export interface Requirements {
     readonly codeChecks: boolean;
@@ -480,7 +480,7 @@ export default function createConfig(
         ignorePhpPlatformRequirements : configurationFromFile.ignore_php_platform_requirements ?? {},
         additionalComposerArguments   : [ ... new Set(configurationFromFile.additional_composer_arguments ?? []) ],
         backwardCompatibilityCheck    : configurationFromFile.backwardCompatibilityCheck ?? false,
-        targetReference               : process.env.GITHUB_BASE_REF ?? null,
+        baseReference                 : process.env.GITHUB_BASE_REF ?? null,
     };
 }
 

src/tools.ts

@@ -51,15 +51,15 @@ function backwardCompatibilityCheckTool(config: Config): ToolRunningContainerDef
         return null;
     }
 
-    if (config.targetReference === null) {
+    if (config.baseReference === null) {
         return null;
     }
 
     return {
         // @TODO need to `git fetch baseSha1` from source repo!
         executionType : ToolExecutionType.STATIC,
         name          : 'Backward Compatibility Check',
-        command       : `roave-backward-compatibility-check check --from="${ config.targetReference }" --install-development-dependencies`,
+        command       : `roave-backward-compatibility-check check --from="${ config.baseReference }" --install-development-dependencies`,
         filesToCheck  : [ 'composer.json' ],
         toolType      : ToolType.CODE_CHECK,
         php           : CONTAINER_DEFAULT_PHP_VERSION,