fix: ensure before_script and/or after_script are non-empty before attempting to cast to array

Bash's `readarray` will fail if a value is an empty string.
As such, we need to test that the value returned from `jq` is not empty before attempting to create an array from it.
Additionally, newlines can cause issues, so this adds logic to strip all newlines.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>

Author: weierophinney

entrypoint.sh

@@ -142,10 +142,18 @@ if [[ "${PHP}" == "" ]];then
 fi
 
 declare -a BEFORE_SCRIPT=()
-readarray -t BEFORE_SCRIPT="$(echo "${JOB}" | jq -rc '(.before_script // [])[]' )"
+BEFORE_SCRIPT_STRING="$(echo "${JOB}" | jq -rc '(.before_script // [])[]' | tr -d '\n')"
+echo "BEFORE_SCRIPT: ${BEFORE_SCRIPT_STRING}"
+if [[ "${BEFORE_SCRIPT_STRING}" != "" ]]; then
+    readarray -t BEFORE_SCRIPT="${BEFORE_SCRIPT_STRING}"
+fi
 
 declare -a AFTER_SCRIPT=()
-readarray -t AFTER_SCRIPT="$(echo "${JOB}" | jq -rc '(.after_script // [])[]' )"
+AFTER_SCRIPT_STRING="$(echo "${JOB}" | jq -rc '(.after_script // [])[]' | tr -d '\n')"
+echo "AFTER_SCRIPT: ${AFTER_SCRIPT_STRING}"
+if [[ "${AFTER_SCRIPT_STRING}" != "" ]]; then
+    readarray -t AFTER_SCRIPT="${AFTER_SCRIPT_STRING}"
+fi
 
 
 echo "Marking PHP ${PHP} as configured default"