Skip to content

Commit e9cfefa

Browse files
authored
Merge pull request #148 from Ocramius/fix/#130-switch-from-phpdbg-to-pcov
Removed `phpdbg`, added `pcov` dependency as part of the build
2 parents a394826 + b233e24 commit e9cfefa

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

Dockerfile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ RUN apt update \
118118
php7.1-intl \
119119
php7.1-json \
120120
php7.1-mbstring \
121+
php7.1-pcov \
121122
php7.1-phar \
122-
php7.1-phpdbg \
123123
php7.1-readline \
124124
php7.1-sockets \
125125
php7.1-xml \
@@ -134,8 +134,8 @@ RUN apt update \
134134
php7.2-intl \
135135
php7.2-json \
136136
php7.2-mbstring \
137+
php7.2-pcov \
137138
php7.2-phar \
138-
php7.2-phpdbg \
139139
php7.2-readline \
140140
php7.2-sockets \
141141
php7.2-xml \
@@ -150,8 +150,8 @@ RUN apt update \
150150
php7.3-intl \
151151
php7.3-json \
152152
php7.3-mbstring \
153+
php7.3-pcov \
153154
php7.3-phar \
154-
php7.3-phpdbg \
155155
php7.3-readline \
156156
php7.3-sockets \
157157
php7.3-xml \
@@ -166,8 +166,8 @@ RUN apt update \
166166
php7.4-intl \
167167
php7.4-json \
168168
php7.4-mbstring \
169+
php7.4-pcov \
169170
php7.4-phar \
170-
php7.4-phpdbg \
171171
php7.4-readline \
172172
php7.4-sockets \
173173
php7.4-xml \
@@ -181,8 +181,8 @@ RUN apt update \
181181
php8.0-fileinfo \
182182
php8.0-intl \
183183
php8.0-mbstring \
184+
php8.0-pcov \
184185
php8.0-phar \
185-
php8.0-phpdbg \
186186
php8.0-readline \
187187
php8.0-sockets \
188188
php8.0-xml \
@@ -196,8 +196,8 @@ RUN apt update \
196196
php8.1-fileinfo \
197197
php8.1-intl \
198198
php8.1-mbstring \
199+
php8.1-pcov \
199200
php8.1-phar \
200-
php8.1-phpdbg \
201201
php8.1-readline \
202202
php8.1-sockets \
203203
php8.1-xml \
@@ -211,8 +211,8 @@ RUN apt update \
211211
php8.2-fileinfo \
212212
php8.2-intl \
213213
php8.2-mbstring \
214+
php8.2-pcov \
214215
php8.2-phar \
215-
php8.2-phpdbg \
216216
php8.2-readline \
217217
php8.2-sockets \
218218
php8.2-xml \

entrypoint.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ echo "Marking PHP ${PHP} as configured default"
152152
update-alternatives --quiet --set php "/usr/bin/php${PHP}"
153153
update-alternatives --quiet --set php-config "/usr/bin/php-config${PHP}"
154154
update-alternatives --quiet --set phpize "/usr/bin/phpize${PHP}"
155-
update-alternatives --quiet --set phpdbg "/usr/bin/phpdbg${PHP}"
156155

157156
# Marks the working directory as safe for the current user prior to checkout
158157
git config --global --add safe.directory '*'
@@ -188,7 +187,6 @@ fi
188187
if [[ "${INI}" != "" ]];then
189188
echo "Installing php.ini settings"
190189
echo "$INI" > "/etc/php/${PHP}/cli/conf.d/99-settings.ini"
191-
echo "$INI" > "/etc/php/${PHP}/phpdbg/conf.d/99-settings.ini"
192190
fi
193191

194192
echo "PHP version: $(php --version)"

scripts/php_ini_dev_settings.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,8 @@ SUBSTITUTIONS+=('s/zend.assertions ?= ?(-1|1)/zend.assertions = 1/')
1515
SUBSTITUTIONS+=('s/opcache.huge_code_pages ?= ?(0|1)/opcache.huge_code_pages = 0/')
1616

1717
for PHP_VERSION in 5.6 7.0 7.1 7.2 7.3 7.4 8.0 8.1 8.2;do
18-
for PHP_SAPI in cli phpdbg; do
19-
INI_FILE="/etc/php/${PHP_VERSION}/${PHP_SAPI}/php.ini"
20-
for SUBSTITUTION in "${SUBSTITUTIONS[@]}";do
21-
sed --in-place -E -e "${SUBSTITUTION}" "${INI_FILE}"
22-
done
18+
INI_FILE="/etc/php/${PHP_VERSION}/cli/php.ini"
19+
for SUBSTITUTION in "${SUBSTITUTIONS[@]}";do
20+
sed --in-place -E -e "${SUBSTITUTION}" "${INI_FILE}"
2321
done
2422
done

0 commit comments

Comments
 (0)