Fix import to match pydocstyle v.1.1.0#191
Conversation
craSH
left a comment
There was a problem hiding this comment.
I just ran across this issue as well, and thought I'd comment that this is the same change I'd have suggested in a PR.
$ pip freeze | grep -e prospector -e pydocstyle
prospector==0.12.2
pydocstyle==1.1.0
And from ipython in that environment:
In [1]: from pydocstyle.checker import PEP257Checker, AllError
In [2]: PEP257Checker
Out[2]: pydocstyle.checker.PEP257Checker
In [3]: AllError
Out[3]: pydocstyle.parser.AllError
|
For backwards compatibility, would it be worth importing from pydocstyle.checker first and then falling back to importing from pydocstyle if an ImportError is raised? |
|
I agree that this approach is the better one to fixing the version, however I merged #190 and made a 0.12.3 release as I didn't have time to thoroughly test this approach yet. I will merge this once I make sure it will work and figure out backwards compatability issues too. Thanks for the really quick PR! |
|
Finally getting around to cleaning up various PRs and issues, sorry it took a while! |
After recent release of
pydocstylepackage prospector fails at importPEP257Checker.This PR corrects import path.