Fix for Profile Options not Fully Merging#40
Closed
jayclassless wants to merge 2 commits into
Closed
Conversation
Member
|
I can't quite remember the logic for the |
Contributor
Author
|
I added a test case. It runs through loading a standard profile, loading a custom profile, and then merging the two. When run on the master branch, this test case fails, as |
carlio
added a commit
to carlio/prospector
that referenced
this pull request
Jan 5, 2015
…ofiles are parsed and combined. This fixes problems with merging and introduces "shorthand" attributes, which are essentially user-friendly ways of inheriting the built-in prospector profiles
Member
|
I ended up rewriting most of how profiles work, so I think your inheritance issue will now be solved. Or worse, but I hope solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up custom profile.yaml files for my projects, I found that the options I was setting for pylint weren't being respected. After some digging, I found that the merging functionality didn't seem to do what it needed to do in order to carry my options over.
The tests around profiles and merging still pass (after modifying one due to removing some functionality in _merge_dict), and my custom profiles are now working as expected. But, you may want to poke at this a bit more to see if I missed something.