Use boolean rather than filled for remember (#423)

Co-authored-by: Chris <[email protected]>

Author: Codeatron5000

src/Actions/RedirectIfTwoFactorAuthenticatable.php

@@ -140,7 +140,7 @@ protected function twoFactorChallengeResponse($request, $user)
     {
         $request->session()->put([
             'login.id' => $user->getKey(),
-            'login.remember' => $request->filled('remember'),
+            'login.remember' => $request->boolean('remember'),
         ]);
 
         TwoFactorAuthenticationChallenged::dispatch($user);

tests/AuthenticatedSessionControllerTest.php

@@ -296,6 +296,35 @@ public function test_two_factor_challenge_can_be_passed_via_code()
             ->assertSessionMissing('login.id');
     }
 
+    public function test_two_factor_authentication_preserves_remember_me_selection(): void
+    {
+        Event::fake();
+
+        app('config')->set('auth.providers.users.model', TestTwoFactorAuthenticationSessionUser::class);
+
+        $this->loadLaravelMigrations(['--database' => 'testbench']);
+
+        Schema::table('users', function ($table) {
+            $table->text('two_factor_secret')->nullable();
+        });
+
+        TestTwoFactorAuthenticationSessionUser::forceCreate([
+            'name' => 'Taylor Otwell',
+            'email' => '[email protected]',
+            'password' => bcrypt('secret'),
+            'two_factor_secret' => 'test-secret',
+        ]);
+
+        $response = $this->withoutExceptionHandling()->post('/login', [
+            'email' => '[email protected]',
+            'password' => 'secret',
+            'remember' => false,
+        ]);
+
+        $response->assertRedirect('/two-factor-challenge')
+            ->assertSessionHas('login.remember', false);
+    }
+
     public function test_two_factor_challenge_fails_for_old_otp_and_zero_window()
     {
         app('config')->set('auth.providers.users.model', TestTwoFactorAuthenticationSessionUser::class);