Add and use constants for session flashes (#409)

* Add and use constants for session flashes

* Apply StyleCI patch

* formatting

Co-authored-by: Taylor Otwell <[email protected]>

Author: dwightwatson

src/Fortify.php

@@ -45,6 +45,14 @@ class Fortify
      */
     public static $registersRoutes = true;
 
+    const PASSWORD_UPDATED = 'password-updated';
+    const PROFILE_INFORMATION_UPDATED = 'profile-information-updated';
+    const RECOVERY_CODES_GENERATED = 'recovery-codes-generated';
+    const TWO_FACTOR_AUTHENTICATION_CONFIRMED = 'two-factor-authentication-confirmed';
+    const TWO_FACTOR_AUTHENTICATION_DISABLED = 'two-factor-authentication-disabled';
+    const TWO_FACTOR_AUTHENTICATION_ENABLED = 'two-factor-authentication-enabled';
+    const VERIFICATION_LINK_SENT = 'verification-link-sent';
+
     /**
      * Get the username used for authentication.
      *

src/Http/Controllers/ConfirmedTwoFactorAuthenticationController.php

@@ -6,6 +6,7 @@
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
 use Laravel\Fortify\Actions\ConfirmTwoFactorAuthentication;
+use Laravel\Fortify\Fortify;
 
 class ConfirmedTwoFactorAuthenticationController extends Controller
 {
@@ -22,6 +23,6 @@ public function store(Request $request, ConfirmTwoFactorAuthentication $confirm)
 
         return $request->wantsJson()
                     ? new JsonResponse('', 200)
-                    : back()->with('status', 'two-factor-authentication-confirmed');
+                    : back()->with('status', Fortify::TWO_FACTOR_AUTHENTICATION_CONFIRMED);
     }
 }

src/Http/Controllers/EmailVerificationNotificationController.php

@@ -27,6 +27,6 @@ public function store(Request $request)
 
         return $request->wantsJson()
                     ? new JsonResponse('', 202)
-                    : back()->with('status', 'verification-link-sent');
+                    : back()->with('status', Fortify::VERIFICATION_LINK_SENT);
     }
 }

src/Http/Controllers/ProfileInformationController.php

@@ -6,6 +6,7 @@
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
 use Laravel\Fortify\Contracts\UpdatesUserProfileInformation;
+use Laravel\Fortify\Fortify;
 
 class ProfileInformationController extends Controller
 {
@@ -23,6 +24,6 @@ public function update(Request $request,
 
         return $request->wantsJson()
                     ? new JsonResponse('', 200)
-                    : back()->with('status', 'profile-information-updated');
+                    : back()->with('status', Fortify::PROFILE_INFORMATION_UPDATED);
     }
 }

src/Http/Controllers/RecoveryCodeController.php

@@ -6,6 +6,7 @@
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
 use Laravel\Fortify\Actions\GenerateNewRecoveryCodes;
+use Laravel\Fortify\Fortify;
 
 class RecoveryCodeController extends Controller
 {
@@ -40,6 +41,6 @@ public function store(Request $request, GenerateNewRecoveryCodes $generate)
 
         return $request->wantsJson()
                     ? new JsonResponse('', 200)
-                    : back()->with('status', 'recovery-codes-generated');
+                    : back()->with('status', Fortify::RECOVERY_CODES_GENERATED);
     }
 }

src/Http/Controllers/TwoFactorAuthenticationController.php

@@ -7,6 +7,7 @@
 use Illuminate\Routing\Controller;
 use Laravel\Fortify\Actions\DisableTwoFactorAuthentication;
 use Laravel\Fortify\Actions\EnableTwoFactorAuthentication;
+use Laravel\Fortify\Fortify;
 
 class TwoFactorAuthenticationController extends Controller
 {
@@ -23,7 +24,7 @@ public function store(Request $request, EnableTwoFactorAuthentication $enable)
 
         return $request->wantsJson()
                     ? new JsonResponse('', 200)
-                    : back()->with('status', 'two-factor-authentication-enabled');
+                    : back()->with('status', Fortify::TWO_FACTOR_AUTHENTICATION_ENABLED);
     }
 
     /**
@@ -39,6 +40,6 @@ public function destroy(Request $request, DisableTwoFactorAuthentication $disabl
 
         return $request->wantsJson()
                     ? new JsonResponse('', 200)
-                    : back()->with('status', 'two-factor-authentication-disabled');
+                    : back()->with('status', Fortify::TWO_FACTOR_AUTHENTICATION_DISABLED);
     }
 }

src/Http/Responses/PasswordUpdateResponse.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Http\JsonResponse;
 use Laravel\Fortify\Contracts\PasswordUpdateResponse as PasswordUpdateResponseContract;
+use Laravel\Fortify\Fortify;
 
 class PasswordUpdateResponse implements PasswordUpdateResponseContract
 {
@@ -17,6 +18,6 @@ public function toResponse($request)
     {
         return $request->wantsJson()
             ? new JsonResponse('', 200)
-            : back()->with('status', 'password-updated');
+            : back()->with('status', Fortify::PASSWORD_UPDATED);
     }
 }