[12.x] Fix Accept header cache invalidation when header is modified (#57874)

* Fix Accept header cache invalidation when header is modified

* Update Request.php

* formatting

---------

Co-authored-by: Taylor Otwell <[email protected]>

Author: faisuc

src/Illuminate/Http/Request.php

@@ -63,6 +63,13 @@ class Request extends SymfonyRequest implements Arrayable, ArrayAccess
      */
     protected $routeResolver;
 
+    /**
+     * The cached "Accept" header value.
+     *
+     * @var string|null
+     */
+    protected $cachedAcceptHeader;
+
     /**
      * Create a new Illuminate HTTP request from server variables.
      *
@@ -356,6 +363,23 @@ public function userAgent()
         return $this->headers->get('User-Agent');
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    #[\Override]
+    public function getAcceptableContentTypes(): array
+    {
+        $currentAcceptHeader = $this->headers->get('Accept');
+
+        if ($this->cachedAcceptHeader !== $currentAcceptHeader) {
+            // Flush acceptable content types so Symfony re-calculates them...
+            $this->acceptableContentTypes = null;
+            $this->cachedAcceptHeader = $currentAcceptHeader;
+        }
+
+        return parent::getAcceptableContentTypes();
+    }
+
     /**
      * Merge new input into the current request's input array.
      *

tests/Http/HttpRequestTest.php

@@ -1425,6 +1425,79 @@ public function testFormatReturnsAcceptsCharset()
         $this->assertTrue($request->accepts('application/baz+json'));
     }
 
+    public function testWantsJsonRespectsHeaderChanges()
+    {
+        $request = Request::create('/', 'GET', [], [], [], ['HTTP_ACCEPT' => '*/*']);
+        
+        $this->assertFalse($request->wantsJson());
+        
+        $this->assertTrue($request->acceptsAnyContentType());
+        
+        $request->headers->set('Accept', 'application/json');
+
+        $this->assertTrue($request->wantsJson(), 'wantsJson() should return true after Accept header is changed to application/json');
+    }
+
+    public function testAcceptsJsonRespectsHeaderChanges()
+    {
+        $request = Request::create('/', 'GET', [], [], [], ['HTTP_ACCEPT' => '*/*']);
+
+        $this->assertTrue($request->acceptsAnyContentType());
+
+        $request->headers->set('Accept', 'application/json');
+
+        $this->assertTrue($request->acceptsJson(), 'acceptsJson() should return true after Accept header is changed to application/json');
+    }
+
+    public function testPrefersRespectsHeaderChanges()
+    {
+        $request = Request::create('/', 'GET', [], [], [], ['HTTP_ACCEPT' => '*/*']);
+        
+        $this->assertTrue($request->acceptsAnyContentType());
+        
+        $request->headers->set('Accept', 'application/json');
+        
+        $this->assertSame('json', $request->prefers(['html', 'json']), 'prefers() should return json after Accept header is changed to application/json');
+    }
+
+    public function testWantsJsonWorksWhenHeaderSetBeforeFirstCall()
+    {
+        $request = Request::create('/', 'GET', [], [], [], []);
+        
+        $request->headers->set('Accept', 'application/json');
+        
+        $this->assertTrue($request->wantsJson(), 'wantsJson() should return true when Accept header is set to application/json');
+    }
+
+    public function testCacheClearedWhenTransitioningFromUnsetToSetHeader()
+    {
+        $request = Request::create('/', 'GET', [], [], [], []);
+        
+        $request->getAcceptableContentTypes();
+        
+        $request->headers->set('Accept', 'application/json');
+        
+        $this->assertTrue($request->wantsJson(), 'wantsJson() should return true after Accept header is set from null to application/json');
+        
+        $this->assertTrue($request->acceptsJson(), 'acceptsJson() should return true after Accept header is set from null to application/json');
+    }
+
+    public function testAcceptsJsonWorksWhenHeaderChangedMultipleTimes()
+    {
+        $request = Request::create('/', 'GET', [], [], [], ['HTTP_ACCEPT' => 'text/html']);
+        
+        $this->assertFalse($request->acceptsJson());
+        
+        $request->headers->set('Accept', 'application/json');
+        $this->assertTrue($request->acceptsJson());
+        
+        $request->headers->set('Accept', 'text/html');
+        $this->assertFalse($request->acceptsJson());
+        
+        $request->headers->set('Accept', 'application/json');
+        $this->assertTrue($request->acceptsJson());
+    }
+
     public function testBadAcceptHeader()
     {
         $request = Request::create('/', 'GET', [], [], [], ['HTTP_ACCEPT' => 'Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-PT; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)']);