Should whereBetween respect DatePeriod inclusion/exclusion flags?

[HeathNaylor]

Right now whereBetween ignores DatePeriod::EXCLUDE_START_DATE and DatePeriod::INCLUDE_END_DATE.

For example:

$period = new DatePeriod(
    new DateTime('2025-01-01'),
    new DateInterval('P1D'),
    new DateTime('2025-01-31'),
    DatePeriod::EXCLUDE_START_DATE
);

Currently we get this for all permutations regardless of which options are passed to DatePeriod:

DB::table('users')->whereBetween('created_at', $period)->toSql(); produces select * from "users" where "created_at" between ? and ?
DB::table('users')->whereNotBetween('created_at', $period)->toSql(); produces select * from "users" where "created_at" not between ? and ?

Since BETWEEN is inclusive on both sides respecting these flags would require switching to comparison operators (>, >=, <, <=) when exclusion is passed and NOT BETWEEN would have OR logic.

What it should produce should look like select * from "users" where ("created_at" > ? and "created_at" < ?) for the EXCLUDE_START_DATE option for example.

This would be a behavior change since DatePeriod excludes the end date by default which would affect existing code passing CarbonPeriod (which extends DatePeriod). This was brought up in #58092.

[shaedrich]

fyi, #58480 tried to implement this but was closed due to lack of sufficient tests (and explanation?). This might not be all, but when having another try, this would at least have to be included

[HeathNaylor]

I have the code written if we decide to do this, it's covered with tests and the explanation is good. That's mostly a canned response anyway and the code was over engineered imo. Once it's decided that this is worth working on I can open the PR.