improved error message for assertSessionHasAll

[stoivo]

I have the following test

post(
    "task/show/$task->id/change_status",
    [
        'task_status_id' => 2,
        'description' => 'Finally!'
    ]
)
    ->assertSessionHas('flash-class', 'success')
    ->assertSessionHas('flash-message', 'Oppdateringen ble lagret')
    ->assertRedirect();

and it fails with this message

Failed asserting that two strings are equal.
Expected :'success'
Actual   :'danger'

Sure. Good to know but I still don't understand why it fails. I can swap the order and inspect flash-message first.

Failed asserting that two strings are equal.
Expected :'Changes saved successfully.'
Actual   :'You do not have permissions to update status on this task.'

That is more helpful! 🎉

Not that happy still. I think we can do better.

post(
    "task/show/$task->id/change_status",
    [
        'task_status_id' => 2,
        'description' => 'Finally!'
    ]
)
    ->tap(function($response) {
        $session = app('session.store');
        expect($session->only(['flash-message', 'flash-class']))->toEqual([
            'flash-class' => 'success',
            'flash-message' => 'Oppdateringen ble lagret'
        ]);
    })
    ->assertRedirect();

Failed asserting that two arrays are equal.
Array (
-    'flash-class' => 'success'
-    'flash-message' => 'Oppdateringen ble lagret'
+    'flash-class' => 'danger'
+    'flash-message' => 'Du har ikke tilgang til å endre status på denne oppgaven.'
)

I like this output. I find it good to get as much info in the error message as possible.

To the question. What do you think? am I wrong? is there a better why to achive this? assertSessionHasAll exists but it loops over the array and asserts each key. We could change the function to work more like this one?

AI also suggested me to use

$errors = [];

try { expect($user->name)->toBe('Alice'); }
catch (Throwable $e) { $errors[] = "name: {$e->getMessage()}"; }

try { expect($user->age)->toBe(30); }
catch (Throwable $e) { $errors[] = "age: {$e->getMessage()}"; }

expect($errors)->toBeEmpty();

Any experience with this approach?

For the record I am using pest