Skip to content

Fixing Inertia SSR errors #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2025
Merged

Fixing Inertia SSR errors #74

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1243797
Adding initial SSR fixes
tnylea Mar 4, 2025
7cae674
fixing warning messages in SSR
tnylea Mar 4, 2025
8889bbc
Adding updates to ssr file to include global route var
tnylea Mar 4, 2025
05d9063
Adding dev:ssr command
tnylea Mar 4, 2025
47dc252
Adding light/dark mode fixes to support cookies and localstorage
tnylea Mar 5, 2025
5414012
updating the intertia return array
tnylea Mar 5, 2025
11df48d
formatting
taylorotwell Mar 6, 2025
1997975
run formatter
taylorotwell Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/Http/Middleware/HandleInertiaRequests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use Illuminate\Foundation\Inspiring;
use Illuminate\Http\Request;
use Inertia\Middleware;
use Tighten\Ziggy\Ziggy;

class HandleInertiaRequests extends Middleware
{
Expand Down Expand Up @@ -38,13 +39,16 @@ public function share(Request $request): array
{
[$message, $author] = str(Inspiring::quotes()->random())->explode('-');

return [
...parent::share($request),
return array_merge(parent::share($request), [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this array_merge() necessary? The React version doesn't use it, though either the spread or the merge will accomplish the same thing. Just wanted to double check so we can keep consistency between the React/Vue templates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right you are, we could use the spread operator here. Thanks!

'name' => config('app.name'),
'quote' => ['message' => trim($message), 'author' => trim($author)],
'auth' => [
'user' => $request->user(),
],
];
'ziggy' => [
...(new Ziggy)->toArray(),
'location' => $request->url(),
],
]);
}
}
7 changes: 6 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
"dev": [
"Composer\\Config::disableProcessTimeout",
"npx concurrently -c \"#93c5fd,#c4b5fd,#fb7185,#fdba74\" \"php artisan serve\" \"php artisan queue:listen --tries=1\" \"php artisan pail --timeout=0\" \"npm run dev\" --names=server,queue,logs,vite"
],
"dev:ssr": [
"npm run build:ssr",
"Composer\\Config::disableProcessTimeout",
"npx concurrently -c \"#93c5fd,#c4b5fd,#fb7185,#fdba74\" \"php artisan serve\" \"php artisan queue:listen --tries=1\" \"php artisan pail --timeout=0\" \"php artisan inertia:start-ssr\" --names=server,queue,logs,ssr"
]
},
"extra": {
Expand All @@ -73,4 +78,4 @@
},
"minimum-stability": "stable",
"prefer-stable": true
}
}
Loading