LLVM: Support logical binop for strings, int, real

Author: Smit-create

src/libasr/codegen/asr_to_llvm.cpp

@@ -4651,14 +4651,48 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
         llvm::Value *left_val = tmp;
         this->visit_expr_wrapper(x.m_right, true);
         llvm::Value *right_val = tmp;
-        LCOMPILERS_ASSERT(ASRUtils::is_logical(*x.m_type))
+        llvm::Value *zero, *cond;
+        if (ASRUtils::is_integer(*x.m_type)) {
+            int a_kind = down_cast<ASR::Integer_t>(x.m_type)->m_kind;
+            int init_value_bits = 8*a_kind;
+            zero = llvm::ConstantInt::get(context,
+                            llvm::APInt(init_value_bits, 0));
+            cond = builder->CreateICmpEQ(left_val, zero);
+        } else if (ASRUtils::is_real(*x.m_type)) {
+            int a_kind = down_cast<ASR::Real_t>(x.m_type)->m_kind;
+            int init_value_bits = 8*a_kind;
+            if (init_value_bits == 32) {
+                zero = llvm::ConstantFP::get(context,
+                                    llvm::APFloat((float)0));
+            } else {
+                zero = llvm::ConstantFP::get(context,
+                                    llvm::APFloat((double)0));
+            }
+            cond = builder->CreateFCmpUEQ(left_val, zero);
+        } else if (ASRUtils::is_character(*x.m_type)) {
+            zero = llvm::Constant::getNullValue(character_type);
+            cond = lfortran_str_cmp(left_val, zero, "_lpython_str_compare_eq");
+        } else if (ASRUtils::is_logical(*x.m_type)) {
+            zero = llvm::ConstantInt::get(context,
+                            llvm::APInt(1, 0));
+            cond = builder->CreateICmpEQ(left_val, zero);
+        } else {
+            throw CodeGenError("Only Integer, Real, Strings and Logical types are supported "
+            "in logical binary operation.", x.base.base.loc);
+        }
         switch (x.m_op) {
             case ASR::logicalbinopType::And: {
-                tmp = builder->CreateAnd(left_val, right_val);
+                tmp = right_val;
+                create_if_else(cond, [=]() {
+                    tmp = left_val;
+                }, []() {});
                 break;
             };
             case ASR::logicalbinopType::Or: {
-                tmp = builder->CreateOr(left_val, right_val);
+                tmp = left_val;
+                create_if_else(cond, [=]() {
+                    tmp = right_val;
+                }, []() {});
                 break;
             };
             case ASR::logicalbinopType::Xor: {