Skip to content

Add new APIs in string object #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Agent-Hellboy opened this issue Oct 2, 2023 · 3 comments
Open

Add new APIs in string object #2356

Agent-Hellboy opened this issue Oct 2, 2023 · 3 comments

Comments

@Agent-Hellboy
Copy link
Contributor

Agent-Hellboy commented Oct 2, 2023

there are 47 public methods in the CPython str object

['capitalize', 'casefold', 'center', 'count', 'encode', 'endswith', 'expandtabs', 'find', 'format', 'format_map', 'index', 

'isalnum', 'isalpha', 'isascii', 'isdecimal', 'isdigit', 'isidentifier', 'islower', 'isnumeric', 'isprintable', 'isspace', 'istitle', 

'isupper', 'join', 'ljust', 'lower', 'lstrip', 'maketrans', 'partition', 'removeprefix', 'removesuffix', 'replace', 'rfind', 

'rindex', 'rjust', 'rpartition', 'rsplit', 'rstrip', 'split', 'splitlines', 'startswith', 'strip', 'swapcase', 'title', 'translate', 'upper', 'zfill']

we have implemented 17 of them if you folks agree, I will try to implement the remaining methods

I have added a PR for join method today

@Agent-Hellboy
Copy link
Contributor Author

Agent-Hellboy commented Oct 2, 2023

Added a PR for 3 of them , will add 1 PR per 3-4 APIs

@certik
Copy link
Contributor

certik commented Oct 2, 2023

@Agent-Hellboy definitely, thank you. I recommend you first finish the PRs you sent, let's get them in. Then send more.

@Agent-Hellboy
Copy link
Contributor Author

@Agent-Hellboy definitely, thank you. I recommend you first finish the PRs you sent, let's get them in. Then send more.

surething

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants