Skip to content

Commit 4a1f697

Browse files
committed
[LDC] PGO: Avoid COMDAT members with private linkage for Windows
To prevent according IR verifier errors with IR-based PGO ('comdat global value has private linkage').
1 parent 88365ac commit 4a1f697

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

llvm/lib/ProfileData/InstrProf.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,8 +340,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
340340
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
341341
Linkage = GlobalValue::LinkOnceODRLinkage;
342342
else if (Linkage == GlobalValue::InternalLinkage ||
343-
Linkage == GlobalValue::ExternalLinkage)
344-
Linkage = GlobalValue::PrivateLinkage;
343+
Linkage == GlobalValue::ExternalLinkage) {
344+
// LDC: use internal instead of private linkage for COFF (still local, but
345+
// allows for COMDATs on Windows)
346+
Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
347+
? GlobalValue::InternalLinkage
348+
: GlobalValue::PrivateLinkage;
349+
}
345350

346351
auto *Value =
347352
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);

0 commit comments

Comments
 (0)