[BUG] Methods.ts doesn't compile #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

DerekTBrown opened this issue Jul 14, 2016 · 0 comments

Assignees

Labels

Milestone

Member

DerekTBrown commented Jul 14, 2016

I had to revert your pull request (#112) because it didn't compile. Lots of problems:

TEST YOUR CODE BEFORE YOU SUBMIT A PULL REQUEST.
We need to move this code because it doesnt make sense for this to be in /labs given it has nothing to do with labs. You can call Meteor.methods multiple times, which means it is safe for you to move this to somewhere which makes more sense.
Please make tests for the search in /tests

DerekTBrown added bug refactor labels

DerekTBrown added this to the alpha.1 milestone

DerekTBrown assigned amortenson

DerekTBrown closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment