fix: patch db init bug (#2657)

carenthomas · web-flow · commit deed6a6cbf26 · 2025-05-23T14:19:17.000-07:00
diff --git a/letta/server/db.py b/letta/server/db.py
@@ -152,16 +152,17 @@ def _build_sqlalchemy_engine_args(self, *, is_async: bool) -> dict:
         if pool_cls:
             base_args["poolclass"] = pool_cls
 
-        if not use_null_pool and not is_async:
+        if not use_null_pool:
             base_args.update(
                 {
                     "pool_size": settings.pg_pool_size,
                     "max_overflow": settings.pg_max_overflow,
                     "pool_timeout": settings.pg_pool_timeout,
                     "pool_recycle": settings.pg_pool_recycle,
-                    "pool_use_lifo": settings.pool_use_lifo,
                 }
             )
+            if not is_async:
+                base_args["pool_use_lifo"] = settings.pool_use_lifo
 
         return base_args
 

Original file line number	Diff line number	Diff line change
`@@ -152,16 +152,17 @@ def _build_sqlalchemy_engine_args(self, *, is_async: bool) -> dict:`
`152`	`152`	`if pool_cls:`
`153`	`153`	`base_args["poolclass"] = pool_cls`
`154`	`154`
`155`		`- if not use_null_pool and not is_async:`
	`155`	`+ if not use_null_pool:`
`156`	`156`	`base_args.update(`
`157`	`157`	`{`
`158`	`158`	`"pool_size": settings.pg_pool_size,`
`159`	`159`	`"max_overflow": settings.pg_max_overflow,`
`160`	`160`	`"pool_timeout": settings.pg_pool_timeout,`
`161`	`161`	`"pool_recycle": settings.pg_pool_recycle,`
`162`		`- "pool_use_lifo": settings.pool_use_lifo,`
`163`	`162`	`}`
`164`	`163`	`)`
	`164`	`+ if not is_async:`
	`165`	`+ base_args["pool_use_lifo"] = settings.pool_use_lifo`
`165`	`166`
`166`	`167`	`return base_args`
`167`	`168`