fix: update release-please config to prevent v-prefix in release titles #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove include-component-in-tag (redundant) - Add tag-separator to explicitly control format - Remove pull-request-title-pattern to avoid interference
There was a problem hiding this comment.
Pull Request Overview
Updates the release-please configuration to ensure GitHub release titles don't include the "v" prefix while maintaining clean Git tags. This addresses inconsistent behavior where include-v-in-tag: false prevents v-prefix in Git tags but not always in release titles for terraform-module release type.
- Replaced
include-component-in-tagwith explicittag-separatorconfiguration - Removed
pull-request-title-patternto prevent configuration interference - Simplified configuration to ensure consistent title formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.release-please-config.jsonto prevent v-prefix appearing in GitHub release titlesinclude-component-in-tag(redundant configuration)tag-separator: ""to explicitly control formatpull-request-title-patternto avoid interferenceBackground
This addresses an issue where
include-v-in-tag: falsecorrectly prevents v-prefix in Git tags but doesn't consistently prevent v-prefix in GitHub release titles for terraform-module release type.Changes
.release-please-config.jsonwith explicit tag separator configurationTest plan