fix: try simple release type to prevent v-prefix in release titles #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove include-component-in-tag (redundant) - Add tag-separator to explicitly control format - Remove pull-request-title-pattern to avoid interference
- Change release-type from terraform-module to simple - Remove tag-separator as it may not be needed with simple type - Keep include-v-in-tag: false for clean tags and titles Testing if simple release type handles v-prefix more consistently between git tags and GitHub release titles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
release-typefromterraform-moduletosimpleto test v-prefix handlingtag-separatorconfiguration (may not be needed with simple type)include-v-in-tag: falsefor clean tags and titlesBackground
The
terraform-modulerelease type appears to handle git tags and GitHub release titles differently, causing v-prefix to appear in release titles despiteinclude-v-in-tag: falsesetting.Hypothesis
The
simplerelease type may handle v-prefix more consistently between git tags and GitHub release titles.Changes
.release-please-config.jsonto usesimplerelease typeTest plan
Expected Result
Next release should have:
0.19.2✅ (already working)0.19.2❌➡️✅ (this is what we're trying to fix)