refactor: Optimize module structure with consolidated repository resources

[Copilot]

This PR optimizes the module structure by consolidating duplicate repository resources and improving the overall organization and readability of the codebase.

Changes

Repository Resource Consolidation

• Replaced separate aws_ecr_repository.repo and aws_ecr_repository.repo_protected resources with a single consolidated resource
• Implemented a dynamic lifecycle block to conditionally apply prevent_destroy = true based on the variable input
• Updated repository references throughout the module to use the consolidated resource

Code Organization & Readability

• Grouped related locals at the top of the file for better discoverability
• Added clear section headers to separate different logical components:
  • Configuration Locals
  • ECR Repository
  • Repository Policies
  • AWS Identity and KMS Resources
  • Logging Resources
• Added descriptive comments to explain complex logic
• Simplified resource references

Dependency Management

• Streamlined depends_on references to point to the single repository resource
• Removed unnecessary dependencies

Backward Compatibility

• Enhanced the moved.tf file to ensure smooth state migration from both previous repository resources
• Maintained the same output structure and values to prevent breaking changes

Benefits

• Reduced code duplication
• Improved maintainability and readability
• Simplified resource dependencies
• More consistent code structure
• Easier future maintenance

Fixes #41.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• _https._tcp.apt.releases.hashicorp.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)
• _https._tcp.esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)
• _https._tcp.motd.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)
• checkpoint-api.hashicorp.com
  • Triggering command: terraform fmt (dns block)
• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)
• motd.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)
• registry.terraform.io
  • Triggering command: terraform init (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[lgallard]

LGTM!