Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 8, 2025

This PR fixes the issue where release-please was adding a "v" prefix to tags despite having "include-v-in-tag": false configured.

Problem

Release-please was creating tags with "v" prefixes (e.g., v0.11.1) even though the configuration was supposed to prevent this. Looking at the CHANGELOG, we can see inconsistent tag prefixes in compare URLs:

## [0.11.1](https://github.com/lgallard/terraform-aws-ecr/compare/0.11.0...v0.11.1)
## [0.11.0](https://github.com/lgallard/terraform-aws-ecr/compare/0.10.0...v0.11.0)
## [0.10.0](https://github.com/lgallard/terraform-aws-ecr/compare/0.9.2...v0.10.0)

Root Cause

The issue was caused by three configuration problems:

  1. Incorrect configuration scope: "include-v-in-tag": false was set at the global level instead of the package-specific level
  2. Workflow parameter conflict: The workflow file had redundant release-type parameter that could override config file settings
  3. Outdated manifest: The manifest version was out of sync with actual releases

Solution

1. Fixed Package-Level Configuration

Moved "include-v-in-tag": false from global to package-specific configuration in .github/.release-please-config.json:

{
  "packages": {
    ".": {
      "release-type": "terraform-module",
      "package-name": "terraform-aws-ecr",
      "include-v-in-tag": false
    }
  }
}

2. Cleaned Up Workflow

Removed redundant release-type parameter from .github/workflows/release-please.yml to avoid conflicts with the config file.

3. Updated Manifest

Synchronized .github/.release-please-manifest.json with the current release version (0.11.1).

Expected Result

Future releases will create tags without the "v" prefix:

  • 0.12.0 instead of v0.12.0
  • ✅ Consistent tag references in CHANGELOG compare URLs
  • ✅ Follows semantic versioning without prefix

All changes are minimal and follow release-please v4 best practices.

Fixes #57.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove "v" prefix in release-please fix: remove "v" prefix from release-please tags Jun 8, 2025
Copilot AI requested a review from lgallard June 8, 2025 15:42
@lgallard
Copy link
Owner

lgallard commented Jun 8, 2025

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 9, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@lgallard lgallard marked this pull request as ready for review June 8, 2025 15:56
@lgallard lgallard merged commit 397c135 into master Jun 8, 2025
@lgallard lgallard deleted the copilot/fix-57 branch June 8, 2025 15:56
@github-actions github-actions bot mentioned this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "v" prefix in release-please

2 participants