fix: remove "v" prefix from release-please tags #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where release-please was adding a "v" prefix to tags despite having
"include-v-in-tag": falseconfigured.Problem
Release-please was creating tags with "v" prefixes (e.g.,
v0.11.1) even though the configuration was supposed to prevent this. Looking at the CHANGELOG, we can see inconsistent tag prefixes in compare URLs:Root Cause
The issue was caused by three configuration problems:
"include-v-in-tag": falsewas set at the global level instead of the package-specific levelrelease-typeparameter that could override config file settingsSolution
1. Fixed Package-Level Configuration
Moved
"include-v-in-tag": falsefrom global to package-specific configuration in.github/.release-please-config.json:{ "packages": { ".": { "release-type": "terraform-module", "package-name": "terraform-aws-ecr", "include-v-in-tag": false } } }2. Cleaned Up Workflow
Removed redundant
release-typeparameter from.github/workflows/release-please.ymlto avoid conflicts with the config file.3. Updated Manifest
Synchronized
.github/.release-please-manifest.jsonwith the current release version (0.11.1).Expected Result
Future releases will create tags without the "v" prefix:
0.12.0instead ofv0.12.0All changes are minimal and follow release-please v4 best practices.
Fixes #57.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.