Potentially deprecate config file path overrides through RepositoryOptions parameters

[nulltoken]

Following the merge of #1123, let's discuss about whether it makes sense or not to keep the config filepaths overrides per repository instances.

Would any of your tools actually still need those per repository instance specialized config file paths now that an appdomain level setting exist?

/cc @shiftkey @rcorre @Therzok @ethomson @carlosmn @spraints @KindDragon

[shiftkey]

Would any of your tools actually still need those per repository instance specialized config file paths now that an appdomain level setting exist?

[spraints]

Would any of your tools actually still need those per repository instance specialized config file paths now that an appdomain level setting exist?

I don't think so, but can you give me an example of what APIs or types of calls would go away if this went away?

[rcorre]

Things like:

var options = new RepositoryOptions { GlobalConfigurationLocation = configPath };

var path = SandboxStandardTestRepoGitDir();
using (var repo = new Repository(path, options)) { ... }

as seen in some LibGit2# tests would go away (not RepositoryOptions as a whole, just the config redirection part).

As far as I'm aware, we don't rely on this at all.

[nulltoken]

/cc @ammeep @shana

[spraints]

😎 IIRC git-tfs uses vanilla config everywhere.

[carlosmn]

We do need this for the tests in order to create isolated repos, but I'm working on making the test suite set this up globally at the start of a fixture instead of only isolating some repos.