Skip to content

Test CanCreateASignedCommit fails in master branch #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AArnott opened this issue May 5, 2016 · 4 comments
Closed

Test CanCreateASignedCommit fails in master branch #1313

AArnott opened this issue May 5, 2016 · 4 comments

Comments

@AArnott
Copy link
Contributor

AArnott commented May 5, 2016

This test fails in the master branch (as of 1fb7fc5)

Test Name:  LibGit2Sharp.Tests.CommitFixture.CanCreateASignedCommit
Test FullName:  LibGit2Sharp.Tests.CommitFixture.CanCreateASignedCommit
Test Source:    C:\Users\andarno\git\libgit2sharp\LibGit2Sharp.Tests\CommitFixture.cs : line 1157
Test Outcome:   Failed
Test Duration:  0:00:00.017

Result StackTrace:  
at LibGit2Sharp.Core.Ensure.HandleError(Int32 result) in C:\Users\andarno\git\libgit2sharp\LibGit2Sharp\Core\Ensure.cs:line 154
   at LibGit2Sharp.Core.Ensure.ZeroResult(Int32 result) in C:\Users\andarno\git\libgit2sharp\LibGit2Sharp\Core\Ensure.cs:line 172
   at LibGit2Sharp.Core.Proxy.git_commit_create_with_signature(RepositoryHandle repo, String commitContent, String signature, String field) in C:\Users\andarno\git\libgit2sharp\LibGit2Sharp\Core\Proxy.cs:line 441
   at LibGit2Sharp.ObjectDatabase.CreateCommitWithSignature(String commitContent, String signature) in C:\Users\andarno\git\libgit2sharp\LibGit2Sharp\ObjectDatabase.cs:line 448
   at LibGit2Sharp.Tests.CommitFixture.CanCreateASignedCommit() in C:\Users\andarno\git\libgit2sharp\LibGit2Sharp.Tests\CommitFixture.cs:line 1163
Result Message: LibGit2Sharp.LibGit2SharpException : malformed commit contents
@ethomson
Copy link
Member

ethomson commented May 5, 2016

That's very surprising, and all our CI is passing here. I would expect this if you were using a slightly older libgit2. Just to be clear: is this with a stock setup? Can you tell me which libgit2.NativeBinaries nuget package you're using?

@AArnott
Copy link
Contributor Author

AArnott commented May 5, 2016

I presume it's using the one that packages.config prescribes, as nuget restore downloaded it:

<package id="LibGit2Sharp.NativeBinaries" version="1.0.137" targetFramework="net4" allowedVersions="[1.0.137]" />

@ethomson
Copy link
Member

ethomson commented May 5, 2016

Aha. Looks to be EOL translation issues.

@ethomson
Copy link
Member

ethomson commented May 5, 2016

Fixed via #1315

@ethomson ethomson closed this as completed May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants