Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.

webrtc-star/simple peer errors, setRemoteDescription #251

Closed
tabcat opened this issue Aug 17, 2020 · 4 comments
Closed

webrtc-star/simple peer errors, setRemoteDescription #251

tabcat opened this issue Aug 17, 2020 · 4 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@tabcat
Copy link
Contributor

tabcat commented Aug 17, 2020

Instructed to move ipfs/js-ipfs#3231 here

@vasco-santos vasco-santos added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked labels Aug 18, 2020
@vasco-santos
Copy link
Member

Thanks for reporting this @tabcat
Would you like to PR this change?

@tabcat
Copy link
Contributor Author

tabcat commented Aug 18, 2020

I can try, I will take a closer look after our HackFS presentation today :)
I've never seen a cannot assign read only property 'message' of object '' error before though, so any info on that would be helpful.

@vasco-santos
Copy link
Member

It seems that who creates the error somehow makes it read only (with a proxy or similar). If that is the case, I think we can just not assign the error message and log it, as there is nothing we can do

@tabcat
Copy link
Contributor Author

tabcat commented Aug 21, 2020

The error that was trying to be logged before the cannot assign read only property 'message' of object '' was DOMException: Failed to construct 'RTCPeerConnection': Cannot create so many PeerConnections if that matters at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants