Merge tag 'v0.24.2' into fdroid

Because Flutter version is now pinned in the pusbpec.yaml, the
flutter-version file was removed

Author: julien4215

.github/workflows/deploy_play_store.yml

@@ -21,17 +21,20 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Set up JDK 17
-        uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
+        uses: actions/setup-java@v5.2.0
         with:
           java-version: 17
           distribution: temurin
 
-      - name: Install Flutter
-        uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2.23.0
-      - run: flutter doctor -v
-
       - name: Checkout mobile code
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@v6.0.2
+
+      - name: Install Flutter
+        uses: subosito/flutter-action@v2.23.0
+        with:
+          channel: stable
+          flutter-version-file: pubspec.yaml
+      - run: flutter --version
 
       - name: Install dependencies
         run: flutter pub get
@@ -40,7 +43,7 @@ jobs:
         run: dart run build_runner build
 
       - name: Setup Fastlane
-        uses: ruby/setup-ruby@c4e5b1316158f92e3d49443a9d58b31d25ac0f8f # v1.306.0
+        uses: ruby/setup-ruby@v1.310.0
         with:
           ruby-version: "3.2"
           bundler-cache: true

.github/workflows/test.yml

@@ -9,7 +9,6 @@ on:
       - 'pubspec.yaml'
     branches:
       - main
-      - v0.18.x
   pull_request:
     paths:
       - 'lib/**'
@@ -18,7 +17,6 @@ on:
       - 'pubspec.yaml'
     branches:
       - main
-      - v0.18.x
 
 # Declare default permissions as read only.
 permissions: read-all
@@ -31,10 +29,10 @@ jobs:
       matrix:
         os: [ubuntu-latest]
     steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - uses: actions/checkout@v6.0.2
 
       - name: 🐦 Install flutter
-        uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2.23.0
+        uses: subosito/flutter-action@v2.23.0
         with:
           cache: true
           flutter-version-file: pubspec.yaml

.github/workflows/upload_fdroid_apks.yml

@@ -25,7 +25,8 @@ jobs:
       - name: Install Flutter
         uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2.23.0
         with:
-          flutter-version: ${{ env.FLUTTER_VERSION }}
+          channel: stable
+          flutter-version-file: pubspec.yaml
 
       - name: Patch Flutter
         run: |

CLAUDE.md

@@ -21,6 +21,7 @@ analyzer:
     - lib/src/styles/social_icons.dart
     - lib/firebase_options.dart
     - lib/l10n/*.dart
+    - build/
   errors:
     invalid_annotation_target: ignore
   # plugins:

analysis_options.yaml

@@ -30,7 +30,11 @@ if (keystorePropertiesFile.exists()) {
 
 android {
     namespace = "org.lichess.mobileV2"
-    compileSdk = flutter.compileSdkVersion
+    // compileSdk = flutter.compileSdkVersion
+    // home_widget pulls in glance-appwidget and remote-creation-android, both of which
+    // declare in their AAR metadata that all dependents (including the app) must compile
+    // against SDK 37+. This cannot be suppressed — it is enforced by AGP at build time.
+    compileSdk = 37
     ndkVersion = flutter.ndkVersion
 
     compileOptions {

android/app/build.gradle.kts

@@ -154,15 +154,23 @@
             android:name="flutterEmbedding"
             android:value="2" />
     </application>
-    <!-- Required to query activities that can process text, see:
-         https://developer.android.com/training/package-visibility and
-         https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT.
-
-         In particular, this is used by the Flutter engine in io.flutter.plugin.text.ProcessTextPlugin. -->
+    <!-- On Android 11+ (API 30) package visibility is restricted: the app can only see/resolve other
+         apps it explicitly declares intents for here. See:
+         https://developer.android.com/training/package-visibility -->
     <queries>
+        <!-- Lets the Flutter engine resolve text-processing apps (io.flutter.plugin.text.ProcessTextPlugin), see:
+             https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT -->
         <intent>
             <action android:name="android.intent.action.PROCESS_TEXT"/>
             <data android:mimeType="text/plain"/>
         </intent>
+        <!-- Lets url_launcher discover a browser/Custom Tabs handler for https. Required for OAuth
+             login: without it, launchUrl() can't resolve a browser on Android 11+ and returns false,
+             so the in-app browser never opens and sign-in fails. -->
+        <intent>
+            <action android:name="android.intent.action.VIEW" />
+            <category android:name="android.intent.category.BROWSABLE" />
+            <data android:scheme="https" />
+        </intent>
     </queries>
 </manifest>

android/app/src/main/AndroidManifest.xml

@@ -2,6 +2,7 @@ package org.lichess.mobileV2
 
 import android.app.ActivityManager
 import android.content.Context
+import android.content.Intent
 import android.graphics.Rect
 import android.os.Bundle
 import android.util.Log
@@ -20,6 +21,16 @@ class MainActivity: FlutterActivity() {
     super.onCreate(savedInstanceState)
   }
 
+  // The OAuth redirect (org.lichess.mobile://login-callback) is delivered here, not in onCreate,
+  // because OAuthCallbackActivity forwards it to this already-running singleTop instance. Flutter's
+  // default handling leaves getIntent() pointing at the stale launch intent, so app_links would read
+  // the wrong URI and the login flow would never receive the callback. setIntent() updates the
+  // activity's current intent to the one carrying the OAuth code so app_links surfaces it correctly.
+  override fun onNewIntent(intent: Intent) {
+    setIntent(intent)
+    super.onNewIntent(intent)
+  }
+
   override fun configureFlutterEngine(flutterEngine: FlutterEngine) {
     super.configureFlutterEngine(flutterEngine)
     MethodChannel(flutterEngine.dartExecutor.binaryMessenger, GESTURES_CHANNEL).setMethodCallHandler {

android/app/src/main/kotlin/org/lichess/mobileV2/MainActivity.kt

@@ -16,6 +16,43 @@ subprojects {
     project.evaluationDependsOn(":app")
 }
 
+// home_widget 0.9.2 skips applying the Kotlin Gradle Plugin when AGP >= 9, assuming the
+// project uses AGP's built-in Kotlin. We keep android.builtInKotlin=false (the app and all
+// other plugins still apply KGP), so home_widget's Kotlin sources would never compile,
+// producing "cannot find symbol HomeWidgetPlugin" at javac time. Apply KGP to it ourselves,
+// right after its android library plugin is applied so ordering is correct.
+subprojects {
+    if (name == "home_widget") {
+        pluginManager.withPlugin("com.android.library") {
+            pluginManager.apply("org.jetbrains.kotlin.android")
+        }
+        // home_widget's own `jvmTarget = "1.8"` is also gated behind the AGP < 9 check, so
+        // Kotlin defaults to a target that doesn't match its Java tasks (compiled at 1.8).
+        // Align Kotlin to 1.8 to avoid "Inconsistent JVM Target Compatibility".
+        tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
+            compilerOptions {
+                jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_1_8)
+            }
+        }
+    }
+}
+
+// Some plugins declare a compileSdk lower than what their transitive dependencies require.
+// gradle.afterProject fires after each project finishes its own configuration, so it
+// runs after the module has set its compileSdk and we can safely override it.
+gradle.afterProject {
+    extensions.findByType(com.android.build.gradle.LibraryExtension::class.java)?.apply {
+        val minRequired = when (project.name) {
+            // glance-appwidget:1.3.0-alpha01 and remote-creation-android:1.0.0-alpha11
+            // both require compileSdk 37+, but home_widget declares only 36.
+            "home_widget" -> 37
+            // sound_effect 0.1.3 declares compileSdk 35 but flutter_plugin_android_lifecycle requires 36+.
+            else -> 36
+        }
+        if ((compileSdk ?: 0) < minRequired) compileSdk = minRequired
+    }
+}
+
 tasks.register<Delete>("clean") {
     delete(rootProject.layout.buildDirectory)
 }

android/build.gradle.kts

@@ -1,3 +1,10 @@
 org.gradle.jvmargs=-Xmx8G -XX:MaxMetaspaceSize=4G -XX:ReservedCodeCacheSize=512m -XX:+HeapDumpOnOutOfMemoryError
 android.useAndroidX=true
 android.enableJetifier=true
+# This builtInKotlin flag was added automatically by Flutter migrator
+android.builtInKotlin=false
+# This newDsl flag was added automatically by Flutter migrator
+android.newDsl=false
+# AGP 9.0 enforces unique package names; cronet-embedded bundles multiple artifacts
+# sharing the org.chromium.net namespace — disable until Chromium fixes this upstream
+android.uniquePackageNames=false