chore(logging): pass exceptions as args to Logger (#3424)

Author: lsaudon

lib/src/app_links_service.dart

@@ -85,7 +85,7 @@ class AppLinksService {
     try {
       await _handleUri(uri, animated: animated);
     } catch (e, st) {
-      _logger.severe('Error handling app link: $e\n$st');
+      _logger.severe('Error handling app link:', e, st);
     }
   }
 
@@ -282,7 +282,7 @@ class AppLinksService {
         } catch (e, st) {
           // Fall back to the current daily puzzle rather than leaving the tap
           // as a no-op when the widget's cached id is stale or unreachable.
-          _logger.info('Failed to load widget puzzle id $puzzleId, falling back: $e', e, st);
+          _logger.info('Failed to load widget puzzle id $puzzleId, falling back:', e, st);
           puzzle = dailyPuzzle;
         }
       }
@@ -297,7 +297,7 @@ class AppLinksService {
         animated: animated,
       );
     } catch (e, st) {
-      _logger.severe('Failed to open daily puzzle from widget: $e\n$st');
+      _logger.severe('Failed to open daily puzzle from widget:', e, st);
     }
   }
 
@@ -312,7 +312,7 @@ class AppLinksService {
 
       return true;
     } catch (e, st) {
-      _logger.info('Not a challenge link: $e', e, st);
+      _logger.info('Not a challenge link:', e, st);
     }
     return false;
   }
@@ -345,7 +345,7 @@ class AppLinksService {
         return [TvScreen.buildRoute(gameId: gameId, user: user, orientation: orientation)];
       }
     } catch (e, st) {
-      _logger.info('Not a game link: $e', e, st);
+      _logger.info('Not a game link:', e, st);
     }
 
     return null;

lib/src/db/database.dart

@@ -44,8 +44,8 @@ Future<int?> _getDatabaseVersion(Database db) async {
     final versionStr = (await db.rawQuery('SELECT sqlite_version()')).first.values.first.toString();
     final versionCells = versionStr.split('.').map((i) => int.parse(i)).toList();
     return versionCells[0] * 100000 + versionCells[1] * 1000 + versionCells[2];
-  } catch (e) {
-    _logger.warning('Error occurred while fetching SQLite version: $e');
+  } catch (e, st) {
+    _logger.warning('Error occurred while fetching SQLite version:', e, st);
     return null;
   }
 }

lib/src/init.dart

@@ -55,7 +55,7 @@ Future<void> initializeApp() async {
       prefs.setString('installed_version', appVersion.canonicalizedVersion);
     }
   } catch (e, st) {
-    _logger.severe('Error during app initialization: $e');
+    _logger.severe('Error during app initialization:', e, st);
     LichessBinding.instance.firebaseCrashlytics.recordError(
       e,
       st,
@@ -93,8 +93,8 @@ Future<void> preloadPieceImages() async {
   if (storedPrefs != null) {
     try {
       boardPrefs = BoardPrefs.fromJson(jsonDecode(storedPrefs) as Map<String, dynamic>);
-    } catch (e) {
-      _logger.warning('Failed to decode board preferences: $e');
+    } catch (e, st) {
+      _logger.warning('Failed to decode board preferences:', e, st);
     }
   }
 
@@ -121,8 +121,8 @@ Future<void> androidDisplayInitialization(WidgetsBinding widgetsBinding) async {
 
       setSystemColors(palette, colorSchemes);
     });
-  } catch (e) {
-    _logger.fine('Device does not support core palette: $e');
+  } catch (e, st) {
+    _logger.fine('Device does not support core palette:', e, st);
   }
 
   // lock orientation to portrait on android phones

lib/src/model/analysis/retro_controller.dart

@@ -141,9 +141,9 @@ class RetroController extends AsyncNotifier<RetroState>
       state = AsyncValue.data(retroState);
 
       if (currentServerAnalysis.value != ServerAnalysisSource.game(gameId: options.id)) {
-        requestServerAnalysis().catchError((Object e, StackTrace s) {
-          _logger.warning('Failed to request server analysis', e, s);
-          state = AsyncError(e, s);
+        requestServerAnalysis().catchError((Object e, StackTrace st) {
+          _logger.warning('Failed to request server analysis', e, st);
+          state = AsyncError(e, st);
         });
       }
 

lib/src/model/analysis/server_analysis_service.dart

@@ -143,8 +143,8 @@ class ServerAnalysisService {
         _currentAnalysis.value = source;
         _socketClient!.firstConnection
             .timeout(const Duration(seconds: 3))
-            .onError((err, st) {
-              _logger.severe('Error connecting to analysis socket', err, st);
+            .onError((e, st) {
+              _logger.severe('Error connecting to analysis socket', e, st);
               _cancelAnalysis();
             })
             .whenComplete(() {

lib/src/model/broadcast/broadcast_analysis_controller.dart

@@ -257,8 +257,8 @@ class BroadcastAnalysisController extends AsyncNotifier<BroadcastAnalysisState>
     final (UciPath? newPath, bool isNewNode) result;
     try {
       result = _root.addMoveAt(path, uciMove, clock: clock);
-    } on PlayException catch (e) {
-      _logger.warning('Could not add broadcast move $uciMove at $path: $e');
+    } on PlayException catch (e, st) {
+      _logger.warning('Could not add broadcast move $uciMove at $path:', e, st);
       _reloadPgn();
       return;
     }

lib/src/model/common/service/sound_service.dart

@@ -87,8 +87,8 @@ class SoundService {
               .soundTheme;
       await _soundEffectPlugin.initialize(maxStreams: _kMaxConcurrentStreams);
       await _loadAllSounds(theme);
-    } catch (e) {
-      _logger.warning('Failed to initialize sound service: $e');
+    } catch (e, st) {
+      _logger.warning('Failed to initialize sound service:', e, st);
     }
   }
 

lib/src/model/correspondence/correspondence_service.dart

@@ -124,8 +124,8 @@ class CorrespondenceService {
             playableGame,
           ),
       ]);
-    } catch (e, s) {
-      _log.warning('Failed to sync correspondence games', e, s);
+    } catch (e, st) {
+      _log.warning('Failed to sync correspondence games', e, st);
     }
   }
 
@@ -204,8 +204,8 @@ class CorrespondenceService {
           _log.info('Cannot play game ${gameToSync.id} move because its state has changed');
           updateStoredGame(gameToSync.fullId, playableGame);
         }
-      } catch (e, s) {
-        _log.severe('Failed to sync correspondence game ${gameToSync.id}', e, s);
+      } catch (e, st) {
+        _log.severe('Failed to sync correspondence game ${gameToSync.id}', e, st);
       } finally {
         streamSubscription?.cancel();
         socket?.close();

lib/src/model/engine/evaluation_service.dart

@@ -408,8 +408,8 @@ class EvaluationService {
       _currentVariant = variant;
 
       _protocol.connected((cmd) => _stockfish.stdin = cmd);
-    } catch (e, s) {
-      _logger.severe('Error initializing engine', e, s);
+    } catch (e, st) {
+      _logger.severe('Error initializing engine', e, st);
       _setEngineState(EngineState.error);
     } finally {
       _initInProgress = false;

lib/src/model/engine/nnue_service.dart

@@ -88,8 +88,8 @@ class NnueService {
     final NNUEFiles files;
     try {
       files = nnueFiles;
-    } catch (e) {
-      _logger.warning('Error getting NNUE files: $e');
+    } catch (e, st) {
+      _logger.warning('Error getting NNUE files:', e, st);
       return false;
     }
 
@@ -111,8 +111,8 @@ class NnueService {
       }
 
       return false;
-    } catch (e) {
-      _logger.warning('Error checking NNUE files: $e');
+    } catch (e, st) {
+      _logger.warning('Error checking NNUE files:', e, st);
       return false;
     }
   }
@@ -129,8 +129,8 @@ class NnueService {
       final NNUEFiles files;
       try {
         files = nnueFiles;
-      } catch (e) {
-        _logger.warning('Error getting NNUE files: $e');
+      } catch (e, st) {
+        _logger.warning('Error getting NNUE files:', e, st);
         return false;
       }