PC relative handling and instr category for AArch32 (#499)

* changes in AArch32 decoder to test using opt fuzz

Author: kumarak

include/remill/Arch/AArch32/Runtime/Types.h

@@ -28,7 +28,7 @@ typedef RnW<uint32_t> R32W;
 
 typedef Rn<uint8_t> R8;
 
-//typedef Rn<uint16_t> R16;
+// typedef Rn<uint16_t> R16;
 typedef Rn<uint32_t> R32;
 
 typedef Vn<vec8_t> V8;

include/remill/Arch/Instruction.h

@@ -60,6 +60,9 @@ class Operand {
     kTypeImmediate,
     kTypeAddress,
     kTypeExpression,
+    kTypeRegisterExpression,
+    kTypeImmediateExpression,
+    kTypeAddressExpression,
   } type;
 
   enum Action { kActionInvalid, kActionRead, kActionWrite } action;

include/remill/BC/Util.h

@@ -252,8 +252,7 @@ std::string ModuleName(const std::unique_ptr<llvm::Module> &module);
 // Replace all uses of a constant `old_c` with `new_c` inside of `module`.
 //
 // Returns the number of constant uses of `old_c`.
-unsigned ReplaceAllUsesOfConstant(llvm::Constant *old_c,
-                                  llvm::Constant *new_c,
+unsigned ReplaceAllUsesOfConstant(llvm::Constant *old_c, llvm::Constant *new_c,
                                   llvm::Module *module);
 
 // Move a function from one module into another module.

lib/Arch/AArch32/Arch.cpp

@@ -124,7 +124,7 @@ void AArch32Arch::PopulateBasicBlockFunction(llvm::Module *module,
   //  auto v512 = llvm::ArrayType::get(llvm::Type::getInt8Ty(context), 512u / 8u);
   auto addr = llvm::Type::getIntNTy(context, address_size);
 
-  //auto zero_addr_val = llvm::Constant::getNullValue(addr);
+  // auto zero_addr_val = llvm::Constant::getNullValue(addr);
 
   const auto entry_block = &bb_func->getEntryBlock();
   llvm::IRBuilder<> ir(entry_block);