Skip to content

Allow site root relative base URLs in *doc & extref directives #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

bantonsson
Copy link
Contributor

@bantonsson bantonsson commented Oct 3, 2017

Not sure if this is the way to go, but I wanted to be able to link to APIs, and files that end up in the same site tree as the generated paradox site, so I added the possibility to have base URLs starting with .../ that are converted to site root relative URLs, in the same way that the image links are converted.

@bantonsson
Copy link
Contributor Author

Anybody got any opinions on this PR?

Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bantonsson bantonsson merged commit f6a7f84 into lightbend:master Oct 10, 2017
@bantonsson bantonsson deleted the ban/site-root-relative-urls branch October 10, 2017 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants