Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Integrate secure PRNG native module for source of entropy for wallet password #777

Closed
tanx opened this issue Nov 6, 2018 · 3 comments · Fixed by #783
Closed

Integrate secure PRNG native module for source of entropy for wallet password #777

tanx opened this issue Nov 6, 2018 · 3 comments · Fixed by #783

Comments

@tanx
Copy link
Contributor

tanx commented Nov 6, 2018

A crypto api for expo is in the works: https://expo.canny.io/feature-requests/p/crypto-api

In the meantime, this seems to be a popular choice: https://github.com/mvayngrib/react-native-randombytes

@tanx tanx mentioned this issue Nov 9, 2018
@tanx tanx changed the title Integrate secure PRNG native module in ejected ExpoKit for source of entropy for wallet password Integrate secure PRNG native module for source of entropy for wallet password Nov 9, 2018
@tanx tanx closed this as completed in #783 Nov 12, 2018
@tanx tanx reopened this Nov 12, 2018
@Overtorment
Copy link

Crypto API for Expo is no longer in the works.
We had same strugle with https://github.com/BlueWallet/BlueWallet and finally ditched Expo in favor of pure RN.

@tanx
Copy link
Contributor Author

tanx commented Dec 12, 2018

Ah nice. Thanks for the heads up. We need to eject to ExpoKit anyway since we need to bundle lnd in a native module, but we still use the expo apis for things like qr code scanning and lightning: linking. So we'll probably stick with expo but just add another native module for the PRNG.

@tanx tanx self-assigned this May 9, 2019
@tanx
Copy link
Contributor Author

tanx commented May 13, 2019

Depends on #1054

This was referenced Jun 5, 2019
@tanx tanx closed this as completed Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants