Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Fix security issue in developer tools breaking the build #784

Closed
tanx opened this issue Nov 9, 2018 · 5 comments
Closed

Fix security issue in developer tools breaking the build #784

tanx opened this issue Nov 9, 2018 · 5 comments

Comments

@tanx
Copy link
Contributor

tanx commented Nov 9, 2018

The build is currently breaking due to a vuln in our development tools: https://travis-ci.org/lightninglabs/lightning-app/jobs/452958355#L857-L871

=== npm audit security report ===                        
                                                                                
# Run  npm install [email protected]  to resolve 1 vulnerability
SEMVER WARNING: Recommended action is a potentially breaking change
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Missing Origin Validation                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ webpack-dev-server                                           │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ react-scripts                                                │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ react-scripts > webpack-dev-server                           │
├───────────────┼─���────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/725                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
@valentinewallace
Copy link
Contributor

I think this is new problem, hopefully this stack overflow question gets traction.

@tanx
Copy link
Contributor Author

tanx commented Nov 12, 2018

I tried to resolve the issue. But we'd have to upgrade to [email protected] and that breaks the build. Haven't been able to get it to work yet. I created an issue here facebook/create-react-app#5777

@Waseemrajashaik
Copy link

solution for this issue please ???

@tanx
Copy link
Contributor Author

tanx commented Jan 10, 2019

The vulnerability is apparently that an adversary could see your source code when running webpack-dev-server. For an open source project like ours not a critical issue. But we'll definitely fix this when we upgrade create-react-app..

@Waseemrajashaik
Copy link

Thanks, @tanx. waiting for the fix 😄

@tanx tanx self-assigned this Jan 30, 2019
@tanx tanx assigned tanx and unassigned tanx Mar 12, 2019
@tanx tanx added the mainnet label Mar 19, 2019
@tanx tanx mentioned this issue Apr 2, 2019
@tanx tanx closed this as completed in #1040 Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants