Skip to content

Commit 41012e4

Browse files
authored
Merge pull request #1311 from 0xfandom/fix/1022-dockerfile-worktree-gitkeep
app: make build/.gitkeep postbuild step git-worktree friendly
2 parents 767c6e8 + 96df490 commit 41012e4

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"start": "BROWSER=none react-scripts start",
99
"develop": "REACT_APP_USE_SAMPLE_DATA=true yarn start",
1010
"build": "react-scripts build",
11-
"postbuild": "git restore build/.gitkeep",
11+
"postbuild": "git restore build/.gitkeep 2>/dev/null || printf '# Keep directory in git.\\n' > build/.gitkeep",
1212
"test": "react-scripts test --env=jest-environment-jsdom --transformIgnorePatterns \"node_modules/(?!d3)/\"",
1313
"test:ci": "cross-env CI=true yarn test --coverage",
1414
"eject": "react-scripts eject",

docs/release-notes/release-notes-0.17.0.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@
1616

1717
### Bug Fixes
1818

19+
* [Fix `dev.Dockerfile` build failure on git
20+
worktree checkouts](https://github.com/lightninglabs/lightning-terminal/pull/1311):
21+
The web UI `postbuild` step no longer aborts when the build context lacks a
22+
reachable git directory, which previously broke `dev.Dockerfile` builds for
23+
contributors using `git worktree`.
24+
1925
* [Restore LNC session setup for mailbox
2026
links](https://github.com/lightninglabs/lightning-terminal/pull/1254):
2127
Mailbox-specific TLS transport credentials now allow mailbox links to proceed

0 commit comments

Comments
 (0)