subservers: remove dependency on tap.UniversePublicAccessStatus*

[ffranr]

Prerequisite change necessary before merging lightninglabs/taproot-assets#1963

[gemini-code-assist]

Summary of Changes

Hello @ffranr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the public access status checks within the taprootAssetsSubServer by replacing constant-based string conversions with direct string comparisons. This change simplifies the code and removes an unnecessary dependency, serving as a prerequisite for a larger upcoming change related to taproot assets.

Highlights

• Dependency Removal: Removed the direct dependency on tap.UniversePublicAccessStatus* constants when checking for public access status in the taprootAssetsSubServer.
• Code Simplification: Simplified the logic for determining publicUniRead and publicUniWrite by directly checking for 'r' and 'w' strings in the Universe.PublicAccess configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• subservers/taproot-assets.go
  • Updated public access status checks to use direct string literals 'r' and 'w' instead of tap.UniversePublicAccessStatus* constants.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes a dependency on tap.UniversePublicAccessStatus* constants by replacing them with their string literal values. While this achieves the goal, it introduces magic strings. I've suggested defining these strings as constants within the package to improve code clarity and maintainability.

[gemini-code-assist]

To improve readability and maintainability, it's better to avoid magic strings. Please define "r" and "w" as constants. You could add them at the top of the file, for example:

const (
	universePublicAccessRead = "r"
	universePublicAccessWrite = "w"
)

Suggested change

	publicUniRead := strings.Contains(t.cfg.Universe.PublicAccess, "r")
	publicUniWrite := strings.Contains(t.cfg.Universe.PublicAccess, "w")
	publicUniRead := strings.Contains(t.cfg.Universe.PublicAccess, universePublicAccessRead)
	publicUniWrite := strings.Contains(t.cfg.Universe.PublicAccess, universePublicAccessWrite)

[jtobin]

Tested w/the associated tapd PR, LGTM. 👍

[lightninglabs-deploy]

@ffranr, remember to re-request review from reviewers when ready