Skip to content

Make litd compile with lnd master dependency set#1259

Open
sergey3bv wants to merge 1 commit into
lightninglabs:masterfrom
sergey3bv:fix/lnd-deps-update
Open

Make litd compile with lnd master dependency set#1259
sergey3bv wants to merge 1 commit into
lightninglabs:masterfrom
sergey3bv:fix/lnd-deps-update

Conversation

@sergey3bv

Copy link
Copy Markdown

Addressing #1255

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves compilation issues with litd when using the lnd master branch by updating several Go module dependencies to their latest compatible versions. It also introduces a flexible mechanism for setting configuration fields in mock objects, which enhances adaptability to future changes in upstream library interfaces.

Highlights

  • Dependency Updates: Updated numerous Go module dependencies in go.mod and go.sum to ensure compatibility with the lnd master branch, addressing compilation issues.
  • Dynamic Configuration: Introduced a new helper function setFieldIfPresent to dynamically set fields in configuration structs, making mock object initialization more robust to upstream interface changes.
  • Code Refactoring: Refactored perms/mock.go and perms/mock_dev.go to utilize the new setFieldIfPresent function for initializing various RPC configurations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies to ensure litd compiles against lnd master. The changes primarily involve version bumps in go.mod and go.sum, including several replace directives to handle breaking API changes in upstream dependencies. Additionally, a refactoring in the perms package introduces a new helper function, setFieldIfPresent, to make mock configurations more resilient to fields being removed from upstream structs.

My review focuses on the new helper function. While the current implementation is fit for its purpose in this PR, I've suggested a small improvement to make it more robust for future use cases by handling nil values more generally.

Comment thread perms/mock_fields.go
@sergey3bv
sergey3bv force-pushed the fix/lnd-deps-update branch from 03ed9ba to f7d4141 Compare March 20, 2026 14:04
@sergey3bv

Copy link
Copy Markdown
Author

Hey, @Roasbeef, @guggero, @ellemouton, could you please review?

@lightninglabs-deploy

Copy link
Copy Markdown

@sergey3bv, remember to re-request review from reviewers when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants